1553389 - On NetBSD: "pipe error: Message too long" in ipc_channel_posix.cc

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[PHO]

User Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Start Firefox normally.

Actual results:

In the Browser Console it shows the same error as the bug 1142693.

Expected results:

There should be no such errors.

It turned out that NetBSD sendmsg(2) sending an fd through a unix domain socket had the same characteristics as Darwin described in the bug 1142693, and thus the same fix needs to be applied. I will attach a patch shortly later. Other BSD kernels may be affected too, but I haven't tested them.

Comment 1

[PHO]

Attachment: fix-sendmsg-netbsd.patch

Sorry for the broken markup. I can't find a way to fix it. Here's the patch.

Comment 2

[Timea Cernea [:tbabos][inactive]]

Given that it is the same as Bug 1142963, moving this over to Core:IPC
Thanks for the report!

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 9066613 [details] [diff] [review]
fix-sendmsg-netbsd.patch

Review of attachment 9066613 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cfb39358f5c
Fix "pipe error: Message too long" on NetBSD

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

In case anyone who sees that commit in the future is wondering about the missing review tag: r=jld, but I forgot to append it before pushing and the commit hooks don't actually enforce that it's present.

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8cfb39358f5c