1553412 - Lots of browser console messages about TelemetryStopWatch keys already initialized

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect, P3)

Description

[Mike Hommey [:glandium]]

I'm getting this repeatedly with Firefox 67:
Error: TelemetryStopwatch: key "FX_SESSION_RESTORE_COLLECT_DATA_MS" was already initialized SessionSaver.jsm:53:33
Error: TelemetryStopwatch: key "FX_SESSION_RESTORE_COLLECT_ALL_WINDOWS_DATA_MS" was already initialized SessionStore.jsm:3415:24

I don't know if that prevents the code that follows to run.

Comment 1

[Mike de Boer [:mikedeboer]]

If these errors are thrown, than yes it would. And that would be very bad(tm). Chris, can you perhaps confirm - or someone else perhaps - if this error is thrown at all?

Comment 2

[Chris H-C :chutten]

It is not thrown, only reported.

This means session restore is misusing the stopwatch in a re-entrant method. It can use an object to pair the starts and stops together if that is what's desired (ie, if the re-entrancy itself isn't the bug)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months and this bug has priority 'P1'.
:dao, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Does this even still reproduce :chutten?

Comment 5

[Chris H-C :chutten]

Dunno. There aren't STR and I don't think I've seen this in my own sessions. Certainly stop doesn't appear in my browserconsole on my Linux nightly, Windows nightly, or Windows beta.

:glandium, do you remember how to reproduce this? Have you seen it recently?

Comment 6

[Mike Hommey [:glandium]]

I think the STR was essentially "start the browser and look at the browser console". But that was 5 years ago. I'm pretty sure I wasn't doing anything special.

Comment 7

[Chris H-C :chutten]

Doesn't happen for me on current Nightly, so happy to call it taken care of until we hear otherwise.