1553413 - TypeError: data is null in PrivacyFilter.jsm

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[Mike Hommey [:glandium]]

This message happens repeatedly in the browser console on Firefox 67:

TypeError: data is nullPrivacyFilter.jsm:49:9

I don't know if that prevents further code to run.

Comment 1

[Mike de Boer [:mikedeboer]]

(In reply to Mike Hommey [:glandium] from comment #0)

I don't know if that prevents further code to run.

I think it most certainly does! Thanks for filing.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r?dao

Comment 3

[Mike de Boer [:mikedeboer]]

[Tracking Requested - why for this release]: This JS error may cause an unexpected degraded session restore experience. The return type of the form data collector changed slightly in bug 1497146, which the PrivacyFilter needs to take into account.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfb0684033ad
Update and harden form data filtering for privacy to account for no data being passed in. r=dao

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bfb0684033ad

Comment 6

[Pascal Chevrel:pascalc]

Mike, do you want to request uplift to beta/release?

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 9066650 [details]
Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Prevents a JavaScript error to be thrown, which may significantly degrade sessionstore reliability and performance.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky, since it's fixing an actual error with a very small not-null-check.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9066650 [details]
Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r?dao

regression fix, approved for 68.0b6

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/33995296c30b

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Do you think this would be important for the 67.0.1 trailhead release? Or can it wait till a 67.0.2?

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

After discussion in team triage today, let's defer till 67.0.2.

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9066650 [details]
Bug 1553413 - Update and harden form data filtering for privacy to account for no data being passed in. r?dao

P1, verified on beta, fix approved for 67.0.2, thanks.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/8b4e5a0c99fa