1553433 - [Win] Text inside the Install/Uninstall Firefox prompt turns blank in high contrast

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Anca Soncutean, Desktop QA]

Attachment: screenshot issue .png

[Affected versions]:

• 69.0a1 (2019-05-21)
• 68.0b3
• 67.0

[Affected platforms]:

• Windows 10 x64
• Windows 8.1 x64

[Steps to reproduce]:

1. Turn on high contrast (except white)
2. Install any affected Firefox version
3. Uninstall the Firefox build

[Expected result]:

• Text inside the Install/Uninstall window is clear and visible.

[Actual result]:

• There is no text inside the Install/Uninstall window.

[Regression range]:

• This doesn’t seem to be a regression, reproducible way back to Fx 49.

[Additional Notes]:

• Issue not reproducible with high contrast white.
• Issue reproducible with Full installer and Stub installer (only for uninstall prompt).

Comment 1

[Molly Howell (she/her) (mostly inactive)]

I'm working on this now.

The full installer has exactly the same problem for the same reason, so I'll fix it here also.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

The stub installer is also kind of affected, but it's a milder case (the text shows up as black-on-white, which is pretty visible, it's just not the colors that are configured), and it's harder to fix, so that's getting a separate bug.

Comment 3

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1553433 - Use the system theme's colors for the installer wizard welcome/finish pages. r=agashlin

We can use MUI_BGCOLOR to change the background color, but there's no way to
globally override the text color, so we additionally need to set that on every
affected control in the Show functions (we have to wait until Show because
that's the earliest point that the controls have been created and we can get
handles to them).

This patch fixes both the full installer and the uninstaller.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/358e1d1cc617
Use the system theme's colors for the installer wizard welcome/finish pages. r=agashlin

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/358e1d1cc617

Comment 6

[Julien Cristau [:jcristau]]

Is this something we may want to fix in esr68?

Comment 7

[Molly Howell (she/her) (mostly inactive)]

I don't know if this is serious enough to uplift this late; this bug has been there since the launch of Windows 8 and never been reported until now, and ESR users are less likely to be running the uninstaller GUI at all. I'd be on board with adding this to 68.1 or 68.2 though.

Comment 8

[Julien Cristau [:jcristau]]

Fair.

Comment 9

[Anca Soncutean, Desktop QA]

This issue is verified fixed with Beta 69.0b6 on Windows 10 x64 and Windows 7 x86.