Open Bug 1553536 Opened 6 years ago Updated 4 months ago

Use minidump-analyzer to append Windows AV/spyware/firewall data to crashreport .extra file; add to telemetry environment data lazily

Categories

(Toolkit :: Crash Reporting, task)

task

Tracking

()

Performance Impact medium
Tracking Status
firefox69 --- affected

People

(Reporter: Gijs, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: main-thread-io, perf, perf:startup, Whiteboard: [fxperfsize:S])

Per discussion in bug 1363586, once we switch the .extra file to be nicer, we can move the AV/firewall/spyware data into the minidump-analyzer code, instead of trying to do the (windows-API-based) IO early on startup.

For telemetry, we can do the same stuff on an idle task later, OMT, after startup, and update the environment then.

Type: defect → task

Gabriele: blast from the past! Do you know if this report is still current? Is the extra file nicer now? ;-)

Flags: needinfo?(gsvelto)
Keywords: perf:startup
Whiteboard: [fxperf:p2] [fxperfsize:S] → [fxperfsize:S]
Performance Impact: --- → P2

Yes, the .extra file is JSON since bug 1420363, adding structured stuff to it should be much easier.

Flags: needinfo?(gsvelto)
Severity: normal → S3

I don't suppose you have an example of a small addition to these annotations that could be used to figure out how to do this? Then I might be able to find time to (finally!) actually do this part. :-)

Flags: needinfo?(gsvelto)

I have! If this information can be retrieved from outside of Firefox then you can do it in the minidump analyzer like we do for the DLL signatures. See the code here that sets the ModuleSignatureInfo crash annotation and the implementation here. We have to call a bunch of Windows function for that and we put them here.

Flags: needinfo?(gsvelto)
You need to log in before you can comment on or make changes to this bug.