1553548 - CSS `contain` needs to inherit from table to table-wrapper-box

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[Daniel Holbert [:dholbert]]

table elements have an anonymous table-wrapper-box which wraps the table-caption and the table, and the table-wrapper-box is the real child of whatever the table's parent-element is.

We need to have contain styling be inherited through from the table to its table-wrapper-box, like we do for lots of other properties. Right now, layout containment and paint containment don't work on tables because we fail to do this.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: testcase for contain-paint (which will become WPT contain-paint-table-002.html)

Here's a testcase that currently fails but will pass when we fix this bug.

This testcase will be included with my patch as WPT "contain-paint-table-002.html". (I'll also have a -001 test which I'm not bothering to attach because it already passes by virtue of the fact that we do honor contain:paint on the table box itself.)

Comment 2

[Daniel Holbert [:dholbert]]

As for contain:layout, that is already covered by this WPT test (which we currently fail):
https://hg.mozilla.org/mozilla-central/raw-file/tip/testing/web-platform/tests/css/css-contain/contain-layout-baseline-005.html

The second item in the final row is an inline-table, which is mispositioned due to this bug here. This bug here will fix that issue, and bug 1552287 will fix the rest of that test.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1553548: [css-contain] Make table-wrapper-box inherit CSS "contain" from table box. r?TYLin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afb705ca89e1
[css-contain] Make table-wrapper-box inherit CSS "contain" from table box. r=TYLin

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16977 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/afb705ca89e1

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged