1553586 - Need to add JSON as a type for ExtensionSettings so it can be used via GPO

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[Mike Kaply [:mkaply]]

Complex policies (like ExtensionSettings) end up getting set via a string in group policy with the JSON.

For that to work, the policy needs JSON as a type in its schema.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1553586 - Need JSON as a type for ExtensionSettings for GPO to work.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1553586: LazyIdleThread should set names for the nsThreads it spawns r=froydnj

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51618e4ce345
Need JSON as a type for ExtensionSettings for GPO to work. r=jaws

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/51618e4ce345

Comment 6

[Mike Kaply [:mkaply]]

Test for this is to verify that something like this works:

{
"policies": {
"ExtensionSettings": "{"*": {"installation_mode": "blocked"}}"
}
}

versus

{
"policies": {
"ExtensionSettings": {
"*": {
"installation_mode": "blocked"
}
}
}
}

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 9067104 [details]
Bug 1553586 - Need JSON as a type for ExtensionSettings for GPO to work.

Beta/Release Uplift Approval Request

• User impact if declined: Unable to use new ExtensionSettings policy with GPO on Windows.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps in bug, have already requested.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minimal policy only change
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This was a missed uplift for 68 that is needed for one of the new policies in 68.
• User impact if declined: Unable to use new ExtensionSettings policy with GPO on Windows.
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minimal policy only change
• String or UUID changes made by this patch:

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

Tested the new policy format in Fx70.0a1 on macOS10.14, ubuntu 18.04 and windows 10 x64. The policy is correctly registered and applied (no addons can be installed).

Please note that the correct policy to apply is:

{
"policies": {
"ExtensionSettings": "{\"*\": {\"installation_mode\": \"blocked\"}}"
}
}

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is also verified fixed in Fx69.0b4 on macOS 10.14, ubuntu 18.04 and windows 10 x64. The policy is correctly registered and applied (no addons can be installed).

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9067104 [details]
Bug 1553586 - Need JSON as a type for ExtensionSettings for GPO to work.

policy fix, approved for 68.0.1 and 68.1esr

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/46eb1d959b33

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Per discussion with jcristau, we're uplifting this to 68.0.1esr also to maintain parity with the non-ESR 68.0.1 release and hopefully avoid some confusion.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

default (68.1esr): https://hg.mozilla.org/releases/mozilla-esr68/rev/568cc46637e226dcb7d4130936b577648ac69d83
FIREFOX_ESR_68_0_X_RELBRANCH (68.0.1esr): https://hg.mozilla.org/releases/mozilla-esr68/rev/861822a3934f2e3b00fbf4f0e5933cc3612fb063

Comment 14

[Cristian Baica [:cbaica], Release Desktop QA]

Tested the fix in Fx68.0.1RC and Fx68.0.1ESR on windows 10 x64, macOS 10.14 and ubuntu 18.04 x64. The ExtensionSettings are correctly applied with json as a type.