Closed Bug 1553650 Opened 4 months ago Closed 4 months ago

[about:addons] AddonList onUninstalling handler should check the addon type and pending operations

Categories

(Toolkit :: Add-ons Manager, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- verified
firefox69 --- verified

People

(Reporter: robwu, Assigned: rpl)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. Open Nightly with extensions.htmlaboutaddons.enabled = true, without extensions.
    E.g. ./mach run --temp-profile --setpref=extensions.htmlaboutaddons.enabled=true about:addons
  2. Switch to the Extensions tab, click on the Gears icon and "Check for updates".
  3. Wait a few seconds.
  4. Click on the Themes tab.
  5. Click on the Extensions tab again.

Expected:

  • No errors

Actual:

It looks like the "Check for updates" action resulted in a plugin update (gmp-gmpopenh264, gmp-widevinecdm).

I also caught this one in Bug 1551490, while I was changing browser_gmpProvider.js to make it run on the HTML about:addons views I noticed this bug and I had to fix it to make that test to complete successfully: onUninstalling should only add the addon to the pendingUninstallAddons Set only if they are actually pending.

See Also: → 1551490
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Summary: JavaScript error: chrome://mozapps/content/extensions/aboutaddons.js, line 1602: TypeError: addon.uninstall is not a function → AddonList onUninstalling handler should check the addon type and pending operations
Attachment #9067138 - Attachment description: Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. mstriemer! → Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer!
Priority: -- → P2
Summary: AddonList onUninstalling handler should check the addon type and pending operations → [about:addons] AddonList onUninstalling handler should check the addon type and pending operations
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/5863d9b390c7
AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer,robwu
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Please request beta uplift if appropriate.

Flags: needinfo?(lgreco)

Comment on attachment 9067138 [details]
Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer!

Beta/Release Uplift Approval Request

  • User impact if declined: Causes test failures (e.g. in browser_gmpProvider.js) when HTML about:addons is enabled by default.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Tiny frontend change and covered by unit tests.
  • String changes made/needed: none
Flags: needinfo?(lgreco)
Attachment #9067138 - Flags: approval-mozilla-beta?

Comment on attachment 9067138 [details]
Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer!

about:addons fix, approved for 68.0b9

Attachment #9067138 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed in Win7x64 and MacOS 10.14.1 using FF70.0a1 (20190710215049), FF69.0b3 and FF68.0 using the steps provided in the first comment. There were no errors displayed when the above steps were performed.

Marking bug as verified fixed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.