1553650 - [about:addons] AddonList onUninstalling handler should check the addon type and pending operations

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Rob Wu [:robwu]]

STR:

1. Open Nightly with extensions.htmlaboutaddons.enabled = true, without extensions.
   E.g. ./mach run --temp-profile --setpref=extensions.htmlaboutaddons.enabled=true about:addons
2. Switch to the Extensions tab, click on the Gears icon and "Check for updates".
3. Wait a few seconds.
4. Click on the Themes tab.
5. Click on the Extensions tab again.

Expected:

• No errors

Actual:

• "TypeError: addon.uninstall is not a function" in the global JS console, at https://searchfox.org/mozilla-central/rev/952521e6164ddffa3f34bc8cfa5a81afc5b859c4/toolkit/mozapps/extensions/content/aboutaddons.js#1611

It looks like the "Check for updates" action resulted in a plugin update (gmp-gmpopenh264, gmp-widevinecdm).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

I also caught this one in Bug 1551490, while I was changing browser_gmpProvider.js to make it run on the HTML about:addons views I noticed this bug and I had to fix it to make that test to complete successfully: onUninstalling should only add the addon to the pendingUninstallAddons Set only if they are actually pending.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5863d9b390c7
AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer,robwu

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5863d9b390c7

Comment 5

[Julien Cristau [:jcristau]]

Please request beta uplift if appropriate.

Comment 6

[Rob Wu [:robwu]]

Comment on attachment 9067138 [details]
Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer!

Beta/Release Uplift Approval Request

• User impact if declined: Causes test failures (e.g. in browser_gmpProvider.js) when HTML about:addons is enabled by default.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Tiny frontend change and covered by unit tests.
• String changes made/needed: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9067138 [details]
Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer!

about:addons fix, approved for 68.0b9

Comment 8

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/59eee64bf66d

Comment 9

[Madalin Cotetiu]

Verified as fixed in Win7x64 and MacOS 10.14.1 using FF70.0a1 (20190710215049), FF69.0b3 and FF68.0 using the steps provided in the first comment. There were no errors displayed when the above steps were performed.

Marking bug as verified fixed.