1553692 - [webvtt] enable wpt 'track-text-track-cue-list.html'

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alastor Wu [:alwu]]

The failure reason of this wpt is that we used the wrong comparion.

For getter, it will return undefined [1] when we can't get the element. We should use assert_equals because undefined is not an object.

For getCueById, it will return null [2] when we can't get the element. We should use assert_equals because null is not an object.

[1] https://heycam.github.io/webidl/#dfn-attribute-getter
[2] https://html.spec.whatwg.org/multipage/media.html#dom-texttrackcuelist-getcuebyid

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1553692 - enable wpt 'track-text-track-cue-list.html'

For getter, it will return undefined [1] when we can't get the element. We should use assert_equals because undefined is not an object.

For getCueById, it will return null [2] when we can't get the element. We should use assert_equals because null is not an object.

[1] https://heycam.github.io/webidl/#dfn-attribute-getter
[2] https://html.spec.whatwg.org/multipage/media.html#dom-texttrackcuelist-getcuebyid

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15f3eb253153
enable wpt 'track-text-track-cue-list.html' r=jib

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17058 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/15f3eb253153

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged