1553694 - Intermittent browser/base/content/test/performance/browser_startup_syncIPC.js | sync IPC PCompositorBridge::Msg_WillClose 1 more times than expected before handling user events -

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=247856554&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/ZBjckuNHSfmiEzSGOFxPsQ/runs/0/artifacts/public/logs/live_backing.log

---

23:26:26 INFO - PCompositorBridge::Msg_MakeSnapshot - at most 1 times
23:26:26 INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_syncIPC.js | sync IPC PLayerTransaction::Msg_GetTextureFactoryIdentifier happened as many times as expected before handling user events -
23:26:26 INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_syncIPC.js | sync IPC PCompositorBridge::Msg_Initialize happened as many times as expected before handling user events -
23:26:26 INFO - Buffered messages finished
23:26:26 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_syncIPC.js | sync IPC PCompositorBridge::Msg_WillClose 1 more times than expected before handling user events -
23:26:26 INFO - Stack trace:
23:26:26 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
23:26:26 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_syncIPC.js:null:241
23:26:26 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
23:26:26 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
23:26:26 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
23:26:26 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
23:26:26 INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_syncIPC.js | sync IPC PCompositorBridge::Msg_MakeSnapshot allowed 1 more times before handling user events -
23:26:26 INFO - whitelisted sync IPC before becoming idle:
23:26:26 INFO - PAPZInputBridge::Msg_ProcessUnhandledEvent - at most 1 times
23:26:26 INFO - PAPZInputBridge::Msg_ReceiveMouseInputEvent - at most 1 times
23:26:26 INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_syncIPC.js | sync IPC PAPZInputBridge::Msg_ProcessUnhandledEvent happened as many times as expected before becoming idle -
23:26:26 INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_syncIPC.js | sync IPC PAPZInputBridge::Msg_ReceiveMouseInputEvent happened as many times as expected before becoming idle -
23:26:26 INFO - Not taking screenshot here: see the one that was previously logged
23:26:26 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_syncIPC.js | Unexpected sync IPC behavior during startup; open the profile_startup_syncIPC.json artifact in the Firefox Profiler to see what happened -
23:26:26 INFO - Stack trace:
23:26:26 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
23:26:26 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_syncIPC.js:null:261
23:26:26 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
23:26:26 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
23:26:26 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
23:26:26 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
23:26:26 INFO - Leaving test bound

Comment 1

[Arthur Iakab [arthur_iakab]]

Done some r/b https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=cd5d8525541fc8a324498043cc250a87632dc72a&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s-4%2Cm%28bc4%29&fromchange=4ff05bda88b2aa7f9aac46bf68b9669b3ad0f655&selectedJob=248391289

and it seems that this started from this push https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s-4%2Cm%28bc4%29&revision=dfabf5135cf1b219f4ea809d4b066ffe5d8a3cef

Brian could you please check if these failures could be from your push?

Comment 2

[Intermittent Failures Robot]

29 failures in 4730 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 15
• mozilla-inbound: 10
• mozilla-central: 4

Platform breakdown:

• windows10-64: 29

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1553694&startday=2019-05-20&endday=2019-05-26&tree=all

Comment 3

[Intermittent Failures Robot]

33 failures in 841 pushes (0.039 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 23
• mozilla-central: 2
• mozilla-inbound: 7
• try: 1

Platform breakdown:

• windows10-64: 16
• windows10-64-qr: 2
• windows10-64-shippable-qr: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1553694&startday=2019-05-28&endday=2019-05-28&tree=all

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1553694 - accept a second PCompositorBridge::Msg_WillClose sync IPC in the 'before handling user events' phase, r=mconley.

Comment 5

[Florian Quèze [:florian]]

Looking at the profiles, we still have only 2 PCompositorBridge::Msg_WillClose sync IPC, and they were already whitelisted 'before first paint'. Having them moved to 'before handling user events' is actually an improvement. From the profile, it seems this is triggered when we are done with the sanitytest window, so the time when it happens probably isn't deterministic. I think we can just whitelist and move on.

Comment 6

[Brian Grinstead [:bgrins]]

Thanks for taking this Florian. I'm not sure why this commit triggered any change at all on windows - the test is only run on osx (https://hg.mozilla.org/integration/autoland/rev/dfabf5135cf1b219f4ea809d4b066ffe5d8a3cef#l1.7) and the one line that changed doesn't have any other test coverage AFAICT.

Comment 7

[Intermittent Failures Robot]

20 failures in 917 pushes (0.022 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15
• mozilla-central: 2
• try: 2
• mozilla-inbound: 1

Platform breakdown:

• windows10-64: 9
• windows10-64-shippable-qr: 9
• windows10-64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1553694&startday=2019-05-29&endday=2019-05-29&tree=all

Comment 8

[Intermittent Failures Robot]

21 failures in 792 pushes (0.027 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 11
• mozilla-inbound: 7
• mozilla-central: 1
• try: 2

Platform breakdown:

• windows10-64-shippable-qr: 6
• windows10-64: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1553694&startday=2019-05-30&endday=2019-05-30&tree=all

Comment 9

[Intermittent Failures Robot]

105 failures in 4337 pushes (0.024 failures/push) were associated with this bug in the last 7 days.

This is the #14 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 64
• mozilla-inbound: 25
• mozilla-central: 11
• try: 5

Platform breakdown:

• windows10-64: 54
• windows10-64-shippable-qr: 46
• windows10-64-qr: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1553694&startday=2019-05-27&endday=2019-06-02&tree=all

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ca9a03071b7
accept a second PCompositorBridge::Msg_WillClose sync IPC in the 'before handling user events' phase, r=mconley.

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0ca9a03071b7

Comment 12

[Intermittent Failures Robot]

10 failures in 5197 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4
• mozilla-inbound: 5
• oak: 1

Platform breakdown:

• windows10-64-shippable-qr: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1553694&startday=2019-06-03&endday=2019-06-09&tree=all