Open Bug 1553695 Opened 2 years ago Updated 2 years ago

Page style "no style" no longer works on local files

Categories

(Firefox :: Menus, defect, P5)

67 Branch
Desktop
All
defect

Tracking

()

Tracking Status
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- wontfix
firefox69 --- fix-optional
firefox70 --- fix-optional

People

(Reporter: yoasif, Unassigned)

References

(Regression)

Details

(Keywords: regression)

As seen on reddit:

https://www.reddit.com/r/firefox/comments/brjtc7/no_page_style_doesnt_work_on_local_files/

STR:

  1. Open local html file with CSS styling.
  2. view -> page style -> no style

What happens:

Page styling doesn't get removed.

Expected result:

As before 67; page styling is removed.

OS: Unspecified → All
Regressed by: 1529762
Hardware: Unspecified → Desktop

Mike, how do you feel about priority here? Is this easy to fix? webextensions don't have access to file:///, and I don't know how easy it is to specify an actor match pattern here that does include files...

Flags: needinfo?(mconley)

ActorManagerChild does its matching using the same logic as the WebExtension URL matcher, but I believe has a broader range of schemes it will allow by default. I believe file:// is one of them.

So, I think we can just add file:// to this list: https://searchfox.org/mozilla-central/source/browser/components/BrowserGlue.jsm#241, and this will work again.

Flags: needinfo?(mconley)
Priority: -- → P5

Firefox version 70 is still affected.

You need to log in before you can comment on or make changes to this bug.