1553759 - 'LZ4_decompress_fast' is deprecated: This function is deprecated and unsafe. Consider using LZ4_decompress_safe() instead

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Frederik Braun [:freddy]]

Source: https://searchfox.org/mozilla-central/rev/952521e6164ddffa3f34bc8cfa5a81afc5b859c4/mfbt/Compression.cpp#41

Full warningtext :

warning: mfbt/Compression.cpp:41:13 [-Wdeprecated-declarations] 'LZ4_decompress_fast' is deprecated: This function is deprecated and unsafe. Consider using LZ4_decompress_safe() instead

Comment 1

[Frederik Braun [:freddy]]

My guess is that the supposed unsafety comes from the caller supplying the output size, but the real source of this warning is a bit unclear to me.

If that's the case, then I think our version is less problematic, given that it casts the output size into a CheckedInt?

code snippet:

bool LZ4::decompress(const char* aSource, char* aDest, size_t aOutputSize) {
  CheckedInt<int> outputSizeChecked = aOutputSize;
  MOZ_ASSERT(outputSizeChecked.isValid());
  int ret = LZ4_decompress_fast(aSource, aDest, outputSizeChecked.value());
  return ret >= 0;
}

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1553759 - Remove unused LZ4::decompress method

The implementation of this method calls deprecated functions and
generates compiler warnings. It is never used, so just remove it.

Comment 3

[Ted Campbell [:tcampbell]]

This function doesn't seem to be used any more. I'd propose we just delete it. Pushing to try to see if things break, but patch is attached.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d0c38d223c9
Remove unused LZ4::decompress method r=froydnj

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4d0c38d223c9

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d0c38d223c9