1553772 - Make accessiblecaret dispatch events more asynchronously.

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1553772 - Bug 1549812 - Don't run arbitrary script from AccessibleCaretManager callbacks.

Instead, post the event for the next turn of the event loop.

In this case, what killed the frame is ActionBarHandler.jsm via
Selection.toString().

Depends on D31088

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1553772 - Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose.

I think these should hold, everything that runs under them should just schedule
other stuff to some later date:

• Synth mouse events -> scheduled as refresh driver observers.
• Scroll events -> Scheduled as well.
• Caret state change events -> Also scheduled after last patch.
• IME and accessibility stuff -> I don't think they can reenter layout.

We can always revert this if it causes troubles, plus it shouldn't crash on
release so should be fine.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1549812 - fix testAccessibleCarets.js to account for more async event dispatching. r=TYLin

I'll land all patches but the first in a separate batch and separate bug for
regression tracking purposes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32d724d2312c
Bug 1549812 - fix testAccessibleCarets.js to account for more async event dispatching. r=TYLin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58d40da71355
Bug 1549812 - Don't run arbitrary script from AccessibleCaretManager callbacks. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/7286e18fbc17
Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats

Comment 6

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1553772) for Geckoview failures in org.mozilla.geckoview.test.SelectionActionDelegateTest.collapseToStart[#designmode]

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247969552&repo=autoland&lineNumber=3865

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7286e18fbc1775558b8653bb63576a47b31a5f3e

Backout:
https://hg.mozilla.org/integration/autoland/rev/781c2bb366d3725e94dc44deab768cd9fd706e75

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Emilio, the tests that caused the backout in comment 6 has been removed in bug 1580832. Maybe it's a good chance to rebase if you still want to land them.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Worth a shot!

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Actually the GeckoView selection tests haven't being removed, but I know how to run those now :)

Android: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5df7041155097ca59bafad5a6d7c9a37f24ee0eb
Desktop tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc3cb38e0e7ba96c6ab534acc70df560e6221314

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4984ebbc98f5
Bug 1549812 - Don't run arbitrary script from AccessibleCaretManager callbacks. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/c154d38e2741
Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4984ebbc98f5
https://hg.mozilla.org/mozilla-central/rev/c154d38e2741