Closed Bug 1553772 Opened 1 year ago Closed 1 year ago

Make accessiblecaret dispatch events more asynchronously.

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files)

No description provided.

Instead, post the event for the next turn of the event loop.

In this case, what killed the frame is ActionBarHandler.jsm via
Selection.toString().

Depends on D31088

I think these should hold, everything that runs under them should just schedule
other stuff to some later date:

  • Synth mouse events -> scheduled as refresh driver observers.
  • Scroll events -> Scheduled as well.
  • Caret state change events -> Also scheduled after last patch.
  • IME and accessibility stuff -> I don't think they can reenter layout.

We can always revert this if it causes troubles, plus it shouldn't crash on
release so should be fine.

I'll land all patches but the first in a separate batch and separate bug for
regression tracking purposes.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32d724d2312c
Bug 1549812 - fix testAccessibleCarets.js to account for more async event dispatching. r=TYLin
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58d40da71355
Bug 1549812 - Don't run arbitrary script from AccessibleCaretManager callbacks. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/7286e18fbc17
Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats
Priority: -- → P3

Emilio, the tests that caused the backout in comment 6 has been removed in bug 1580832. Maybe it's a good chance to rebase if you still want to land them.

Worth a shot!

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Attachment #9066988 - Attachment description: Bug 1549812 - Don't run arbitrary script from AccessibleCaretManager callbacks. r=TYLin → Bug 1553772 - Bug 1549812 - Don't run arbitrary script from AccessibleCaretManager callbacks.
Attachment #9066989 - Attachment description: Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats → Bug 1553772 - Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4984ebbc98f5
Bug 1549812 - Don't run arbitrary script from AccessibleCaretManager callbacks. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/c154d38e2741
Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.