1553900 - objdir/dist/include/WavDumper.h:35:5: error: 'SprintfLiteral' was not declared in this scope

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jan Beich]

GeckoProfiler (formerly, SPS profiler) is not available on many Tier3 platforms but bug 1552530 relies on a header conditionally included.

In file included from dom/media/DecoderTraits.cpp:14:
In file included from objdir/dist/include/OggDemuxer.h:11:
In file included from objdir/dist/include/OggCodecState.h:11:
In file included from objdir/dist/include/FlacFrameParser.h:13:
In file included from objdir/dist/include/MediaDecoder.h:19:
In file included from objdir/dist/include/MediaStreamGraph.h:9:
In file included from objdir/dist/include/AudioStream.h:20:
objdir/dist/include/WavDumper.h:35:5: error: use of undeclared
identifier 'SprintfLiteral'
SprintfLiteral(buf, "%s-%d.wav", aBaseName, ++sDumpedAudioCount);
^
1 error generated.

https://searchfox.org/mozilla-central/rev/662de518b168/tools/profiler/public/GeckoProfiler.h#80

In file included from dom/media/DecoderTraits.cpp:8:
In file included from dom/media/MediaContainerType.h:10:
In file included from dom/media/MediaMIMETypes.h:10:
In file included from dom/media/VideoUtils.h:18:
In file included from objdir/dist/include/mozilla/MozPromise.h:13:
In file included from objdir/dist/include/mozilla/Monitor.h:10:
In file included from objdir/dist/include/mozilla/CondVar.h:15:
objdir/dist/include/GeckoProfiler.h:80:2: error: bootlegging check

Comment 1

[Jan Beich]

Platforms without GeckoProfiler are Linux powerpc*/sparc*/s390x, Solaris, DragonFly, FreeBSD, NetBSD, OpenBSD.So, in order to reproduce before bug 1371159 on Tier1 one would have to force gecko_profiler return None.

https://searchfox.org/mozilla-central/rev/662de518b168/toolkit/moz.configure#61-66

No clue if dom/media/ is included in Gecko's media bindings for Rust (see bug 1403868).

Comment 2

[Jan Beich]

Attachment: fix

Sorry, I can't submit on Phabricator due to bug 1536716.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=190add02fc61c11e96551249ae84734d9d2a4121

Comment 3

[Jan Beich]

Can you help landing the fix?

Comment 4

[Paul Adenot (:padenot)]

(In reply to Jan Beich from comment #3)

Can you help landing the fix?

Sure thing, I'll take care of it, thanks for the patch, and sorry to have regressed this!

Comment 5

[Jan Beich]

https://hg.mozilla.org/integration/autoland/rev/89e071495832 (bug number is incorrect)

Comment 6

[Jan Beich]

https://hg.mozilla.org/mozilla-central/rev/89e071495832