GeckoViewExternalAppService.js does not implement nsIMIMEService
Categories
(GeckoView :: General, defect, P2)
Tracking
(firefox68 affected, firefox69 affected)
People
(Reporter: gbrown, Unassigned)
References
(Regression)
Details
(Keywords: leave-open, regression)
Attachments
(1 file)
GeckoViewExternalAppService.js supplies @mozilla.org/uriloader/external-helper-app-service;1
but it lacks some of the associated interfaces normally implemented by nsExternalHelperAppService.
Notably it provides an implementation of nsIExternalHelperAppService but not nsIMIMEService, causing failures in code like:
return Cc["@mozilla.org/uriloader/external-helper-app-service;1"]
.getService(Ci.nsIMIMEService)
.getTypeFromFile(file);
This is why several xpcshell tests fail when run against a geckoview build.
Comment 1•5 years ago
|
||
Geoff, does this nsIMIMEService issue block us from enabling any xpcshell tests or does it just cause some test cases to fail?
Reporter | ||
Comment 2•5 years ago
|
||
It causes some tests to fail, but it is a lot of tests, not just a few. I think we need this issue resolved before we can switch xpcshell from fennec to geckoview.
Reporter | ||
Comment 3•5 years ago
|
||
Does it matter how nsIMIMEService is obtained? I wouldn't think so, tests continue
to pass with this change, and this will allow me to move ahead with running
xpcshell against geckoview.
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8cf07d8ce4ea Bypass external-helper-app-service when getting mime service in httpd.js; r=mayhemer
Reporter | ||
Comment 5•5 years ago
|
||
With this change I should be able to proceed with bug 1553225. However, let's leave open to revisit the GeckoViewExternalAppService.js implementation.
Comment 6•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 7•3 years ago
|
||
GeckoViewExternalAppService changed a bit since this bug was open, so I'm going to close this as fixed, please open a new bug if there's anything left here.
Updated•2 years ago
|
Updated•2 years ago
|
Description
•