1553944 - Fix some compile errors in mailnews

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

We need to include('/ipc/chromium/chromium-config.mozbuild') and more.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1553944.patch

No idea why I got compile errors in nsMessengerWinIntegration.cpp. Looks like the string types were always wrong. Maybe the chromium setup tightened the rules. Hmm.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cec9658e7919
Fix mailnews/ compile errors after bug 1525720. rs=bustage-fix

Comment 3

[Geoff Lankow (:darktrojan)]

This broke the build:

../config/tests/test_mozbuild_reading.py::TestMozbuildReading::test_filesystem_traversal_no_config TEST-UNEXPECTED-FAIL

BuildReaderError:
==============================
FATAL ERROR PROCESSING MOZBUILD FILE
==============================

The error occurred while processing the following file:

    /builds/worker/workspace/build/src/comm/mailnews/base/moz.build

The underlying problem is an illegal file access. This is likely due to trying to access a file outside of the top source directory.

The path whose access was denied is:

    /ipc/chromium/chromium-config.mozbuild

Modify the script to not access this file and try again.

Probably because mozreltopsrcdir is not available without a config.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a137395d1db
follow-up - Fix broken build checks; rs=bustage-fix-fix