1553945 - No keyboard shortcut for standalone history library window on mac

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Trevor Rowbotham [:rowbot]]

A reddit[1] user has reported that the keyboard shortcut Cmd + Shift + H does not open the history library window on mac, but instead opens the history sidebar. I would have assumed the documentation[2] would be common common to all os.

[1] https://www.reddit.com/r/firefox/comments/bs57jy/whats_the_mac_shortcut_for_opening_the_history/
[2] https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly?redirectlocale=en-US&as=u&redirectslug=Keyboard+shortcuts&utm_source=inproduct#w_history

Comment 1

[Trevor Rowbotham [:rowbot]]

It has been brought to my attention that Cmd + H is a system shortcut on mac for hiding windows. Perhaps another sensible key combination could be found to be used to open the History Libarary on mac.

Comment 2

[:Gijs (he/him)]

(In reply to Trevor Rowbotham [:rowbot] from comment #0)

I would have assumed the documentation[2] would be common common to all os.

[2] https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly?redirectlocale=en-US&as=u&redirectslug=Keyboard+shortcuts&utm_source=inproduct#w_history

There are a number of OS-specific differences because of expectations from OS browsers (e.g. historical shortcut compat with IE on Windows), and shortcuts being more or less available on some OSes (e.g. F keys on macOS) and shortcut keys being in use by the OS.

You can select which OS you display shortcuts for on that page by means of the dropdown on the right of the page.

Comment 3

[Asif Youssuff]

What is everyone's thoughts on making the Library window appear with Command-y?

That is the History shortcut in Safari, Chromium and Edge and there are no conflicts in Firefox as far as I can tell.

Comment 4

[:Gijs (he/him)]

(In reply to Asif Youssuff from comment #3)

What is everyone's thoughts on making the Library window appear with Command-y?

Doing this on mac seems reasonable to me. If you want to fix this you'd need to add an entry like https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/base/content/browser-sets.inc#218 to the mac-specific #else block of the preprocessor macro, with its own data-l10n-id and different modifiers, and then remove the ifndef around https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/base/content/browser-menubar.inc#256 . Then add the new data-l10n-id with Y into browserSets.ftl .

Comment 5

[Asif Youssuff]

Attachment: Bug 1553945 - Added a keyboard shortcut to show history on macOS r?mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/170550855ee2
Added a keyboard shortcut to show history on macOS r=mak,fluent-reviewers,flod

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/170550855ee2