1554072 - Crash in [@ mozilla::dom::Document::CreateElement]

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-5cc01802-d56f-4fdf-981c-da5080190524.

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::Document::CreateElement dom/base/Document.cpp:5531
1 xul.dll static bool mozilla::dom::Document_Binding::createElement dom/bindings/DocumentBinding.cpp:1367
2 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3165
3 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:538
4 xul.dll static bool InternalCall js/src/vm/Interpreter.cpp:593
5 xul.dll static bool Interpret js/src/vm/Interpreter.cpp:3085
6 xul.dll js::RunScript js/src/vm/Interpreter.cpp:423
7 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:566
8 xul.dll static bool InternalCall js/src/vm/Interpreter.cpp:593
9 xul.dll js::Call js/src/vm/Interpreter.cpp:609

There are 34 crashes (from 7 installations) in nightly 69 with buildid 20190523215203. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1551320.
The moz_crash_reason is: MOZ_RELEASE_ASSERT(false) (CreateElement() not allowed in XUL document.)

[1] https://hg.mozilla.org/mozilla-central/rev?node=6d063a63bece

Comment 1

[Marcia Knous [:marcia]]

Changing to all as there are crashes on Mac, Linux and Windows.

Comment 2

[Brendan Dahl [:bdahl]]

We really need a JS stack here to figure out where createElement is still being called. I need to figure out how to create a sanitized chrome only JS stack, but in the mean time we can just make this a debug only assert.

Comment 3

[Brendan Dahl [:bdahl]]

Attachment: Bug 1554072 - Only crash in debug builds when using createElement with XUL. r=bzbarsky

Temporary solution until we get sanitized chrome JS stacks for the crash
reporter.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e495155bbdd1
Only crash in debug builds when using createElement with XUL. r=bzbarsky

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e495155bbdd1