1554083 - [wpt-sync] Sync PR 16992 - Revert "Frame freezing on load."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 16992 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16992
Details from upstream follow.

Yuki Shiino <[e-mail]> wrote:

Revert "Frame freezing on load."

This reverts commit 0daefdcf34ba9a8c21ab907b2159c5652169a45b.

Reason for revert:
DCHECK(!GetDocument()->LoadEventStillNeeded());
in local_frame.cc is failing at
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29

Original change's description:

Frame freezing on load.

Move load event checks to renderer side so it is consistent with the
page lifecycle spec. Add additional resource that is slow to load
to ensure the load event is waited for correctly before freezing.

BUG=907125

Change-Id: I8f45ddffcf3ce88f6244307833325a54e1c2d395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625464
Reviewed-by: Kentaro Hara \<[e-mail]>
Reviewed-by: Avi Drissman \<[e-mail]>
Commit-Queue: Dave Tapuska \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#662340}

TBR=[e-mail],[e-mail],[e-mail]

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 907125
Change-Id: I4e27e30519359e2a3ef0d2c92a0fc9d88ac78aff

Reviewed-on: https://chromium-review.googlesource.com/1628499
WPT-Export-Revision: 2513cb69cefe4b95d8a484b830ccc72026dfd710

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c728810e3759fdba5ca4518a2f9bab252b7cd366

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cd5aae549a4030a0b584ff6d66c512148f08494

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b5ce266625e
[wpt PR 16992] - Revert "Frame freezing on load.", a=testonly

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6b5ce266625e

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6b5ce266625e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17463 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1111be9684b
[wpt PR 17463] - [Gecko Bug 1554083] [wpt PR 16992] - Revert "Frame freezing on load.", a=testonly, a=testonly

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b1111be9684b