1554133 - Add a localization wrapper

Status: RESOLVED FIXED

(DevTools :: Application Panel, enhancement, P1)

Description

[Belén [:ladybenko]]

Let's add a localization wrapper like the one in remote debugging: https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging-new/src/modules/l10n.js

• Encapsulate the setup of Fluent
• Provide easy-to-use getString method

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1554133 - Part 1: move about:debugging's l10n module to a shared folder

Comment 2

[Belén [:ladybenko]]

Attachment: Bug 1554133 - Part 2: make app panel to use the shared fluent l10n module

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48321582c78
Part 1: move about:debugging's l10n module to a shared folder r=jdescottes,Ola
https://hg.mozilla.org/integration/autoland/rev/72ae1ac933ac
Part 2: make app panel to use the shared fluent l10n module r=jdescottes,Ola

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 2 changesets (Bug 1554133) for package related build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=b51ad1728a4cc193fb60629437dd0c21bb97145c&tochange=c2c7a9b88d01b828960ef856faeb575234bc4dd3&selectedJob=249933225

Backout link: https://hg.mozilla.org/integration/autoland/rev/c2c7a9b88d01b828960ef856faeb575234bc4dd3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249933225&repo=autoland&lineNumber=38616

task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package> Duplicates 12923 bytes:
[task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package> browser/chrome/icons/default/default128.png
[task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package> browser/chrome/browser/content/branding/icon128.png
[task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package>
[task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package> Duplicates 19892 bytes:
[task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package> browser/features/[e-mail]/chrome/content/autofillEditForms.js
[task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package> browser/chrome/browser/res/payments/formautofill/autofillEditForms.js
[task 2019-06-04T13:57:30.118Z] 13:57:30 INFO - package>
[task 2019-06-04T13:57:30.119Z] 13:57:30 INFO - package> WARNING: Found 28 duplicated files taking 84322 bytes (uncompressed)
[task 2019-06-04T13:57:30.119Z] 13:57:30 INFO - package> ERROR: The following duplicated files are not allowed:
[task 2019-06-04T13:57:30.119Z] 13:57:30 INFO - package> browser/chrome/devtools/modules/devtools/client/aboutdebugging-new/src/modules/l10n.js
[task 2019-06-04T13:57:30.119Z] 13:57:30 INFO - package> browser/chrome/devtools/modules/devtools/client/application/src/modules/l10n.js
[task 2019-06-04T13:57:30.119Z] 13:57:30 INFO - package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:23: recipe for target 'stage-package' failed
[task 2019-06-04T13:57:30.119Z] 13:57:30 ERROR - package> make[5]: *** [stage-package] Error 1
[task 2019-06-04T13:57:30.119Z] 13:57:30 INFO - package> make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/installer'
[task 2019-06-04T13:57:30.119Z] 13:57:30 INFO - package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:103: recipe for target 'make-package' failed
[task 2019-06-04T13:57:30.119Z] 13:57:30 ERROR - package> make[4]: *** [make-package] Error 2
[task 2019-06-04T13:57:30.120Z] 13:57:30 INFO - package> /builds/worker/workspace/build/src/config/rules.mk:400: recipe for target 'default' failed
[task 2019-06-04T13:57:30.120Z] 13:57:30 ERROR - package> make[3]: *** [default] Error 2
[task 2019-06-04T13:57:30.120Z] 13:57:30 INFO - package> /builds/worker/workspace/build/src/browser/build.mk:6: recipe for target 'package' failed
[task 2019-06-04T13:57:30.121Z] 13:57:30 ERROR - package> make[2]: *** [package] Error 2
[task 2019-06-04T13:57:30.121Z] 13:57:30 INFO - /builds/worker/workspace/build/src/build/moz-automation.mk:84: recipe for target 'automation/package' failed
[task 2019-06-04T13:57:30.121Z] 13:57:30 ERROR - make[1]: *** [automation/package] Error 2
[task 2019-06-04T13:57:30.121Z] 13:57:30 INFO - make[1]: *** Waiting for unfinished jobs....
[task 2019-06-04T13:57:50.321Z] 13:57:50 INFO - package-tests> make[3]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/tests'
[task 2019-06-04T13:57:50.321Z] 13:57:50 INFO - package-tests> ../../../config/nsinstall -D ../../../dist/test-stage/jsreftest/tests
[task 2019-06-04T13:57:50.321Z] 13:57:50 INFO - package-tests> (cd /builds/worker/workspace/build/src/js/src/tests && tar -chf - jsreftest.html shell.js browser.js js-test-driver-end.js user.js non262/ shell/ test/ test262/ whatwg/ ) | (cd ../../../dist/test-stage/jsreftest/tests && tar -xf -)
[task 2019-06-04T13:57:50.321Z] 13:57:50 INFO - package-tests> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/js/src/tests/jstests.py --make-manifests ../../../dist/test-stage/jsreftest/tests/
[task 2019-06-04T13:57:50.321Z] 13:57:50 INFO - package-tests> make[3]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/tests'
[task 2019-06-04T13:58:11.434Z] 13:58:11 INFO - package-tests> make[2]: Entering directory '/builds/worker/workspace/build/src/obj-firefox'

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f884c61318f
Part 1: move about:debugging's l10n module to a shared folder r=jdescottes,Ola
https://hg.mozilla.org/integration/autoland/rev/e0331af1213a
Part 2: make app panel to use the shared fluent l10n module r=jdescottes,Ola

Comment 6

[Belén [:ladybenko]]

Updated patch to fix the issue

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1f884c61318f
https://hg.mozilla.org/mozilla-central/rev/e0331af1213a