155421 - stylesheet advisory MIME type handling code is fishy

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The code in nsHTMLContentSink::ProcessStyleLink looks very fishy -- checking for
a .css extension in strict mode.  I'd think the advisory MIME type is omissible,
although we might want to be stricter about the server MIME type in those cases.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: same as diff -uw for review

Comment 3

[Boris Zbarsky [:bzbarsky]]

taking

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 107542 [details] [diff] [review]
same as diff -uw for review

sr=dbaron.  I thought you've been advocating more context around diffs, though.
:-)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Mea culpa.  I was trying to do too many things at once and forgot to type the 6.  ;)

Checked in.