Closed
Bug 1554241
Opened 6 years ago
Closed 6 years ago
Protections Panel header gradient looks wrong in RTL mode
Categories
(Firefox :: Site Identity, defect, P1)
Firefox
Site Identity
Tracking
()
VERIFIED
FIXED
Firefox 69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: nhnt11)
References
Details
(Keywords: rtl, Whiteboard: [privacy-panel])
Attachments
(2 files)
Screenshot
See the screenshot. The arrow for the panel is drawn in the colour corresponding to the area to the left of the panel, whereas the arrow appears on the top-right of the panel.
|
||
Updated•6 years ago
|
Whiteboard: [privacy-panel][triage]
|
Reporter | |
Comment 1•6 years ago
|
||
|
|
||
Updated•6 years ago
|
Priority: -- → P1
Whiteboard: [privacy-panel][triage] → [privacy-panel]
|
Assignee | |
Comment 2•6 years ago
|
||
There are two solutions here: either we reverse the gradient or colour the arrow based on the right hand side. :epang said we should do the latter.
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ddac5f5e3de
Apply different color to protections panel arrow in RTL to match gradient. r=johannh
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
|
||
Updated•6 years ago
|
Assignee: nobody → nhnt11
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
||
Comment 6•6 years ago
|
||
Can confirm with the current Nightly build 70.0a1 (2019-07-28) that the panel colors are in order.
Clearing the QE+ flag since this shouldn't be enabled(by default) on the current beta builds.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•