Closed Bug 1554256 Opened 5 months ago Closed 5 months ago

Read GeckoView configuration file in release builds when package is the current Android "debug-app"

Categories

(GeckoView :: General, defect)

Unspecified
All
defect
Not set

Tracking

(firefox68 fixed, firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Bug 1533385 taught GeckoView to read configuration from a file. But right now, release APKs don't read that configuration: see the documentation at See https://mozilla.github.io/geckoview/tutorials/automation.html#enabling-reading-configuration-from-a-file-for-release-builds. However, Android has a flag -- the "debug-app" flag -- that Chrome uses to control this configuration file behaviour, and this ticket tracks making GeckoView do that too.

In particular, harnesses can use am {set,clear}-debug-app ... (see https://developer.android.com/studio/command-line/adb) to set the flag, and then it can be read in GeckoView using https://developer.android.com/reference/android/provider/Settings.Global.html#DEBUG_APP.

Bug 1533385 taught GeckoView to read configuration from a file. But
right now, release APKs don't read that configuration: see the
documentation at See
https://mozilla.github.io/geckoview/tutorials/automation.html#enabling-reading-configuration-from-a-file-for-release-builds.
However, Android has a flag -- the "debug_app" flag -- that Chrome
uses to control this configuration file behaviour, and this commit
makes GeckoView uses that flag as well.

To use this, invoke adb shell am set-debug-app --persistent PACKAGE
(see https://developer.android.com/studio/command-line/adb).

Attachment #9067405 - Attachment description: Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r?#geckoview-reviewers → Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r?snorp
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57f0a1d67c3e
Read GeckoView configuration file in release builds when package is the current Android "debug-app". r=geckoview-reviewers,snorp
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → nalexander

Comment on attachment 9067405 [details]
Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r?snorp

Beta/Release Uplift Approval Request

  • User impact if declined: It will be difficult to control GeckoView parameters in automation for Fenix, which is planning to ship on GV 68.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Worst case, this crashes in some way in the wild. It's a JVM crash, so we should get very good stacktraces for such crashes.
  • String changes made/needed:
Attachment #9067405 - Flags: approval-mozilla-beta?

Comment on attachment 9067405 [details]
Bug 1554256 - Read GeckoView configuration file in release builds when package is the current Android "debug-app". r?snorp

geckoview fix for 68.0b7

Attachment #9067405 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.