1554387 - Make sure no other periodic filter run is started while another is running

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[:aceman]

When a periodic filter is run on a big folder with many messages to change, it may run longer than the interval between filter runs (10 minutes by default). This may happen when a periodic filter rules/actions change and many messages must be touched. Or when TB wasn't started for a long time and many new messages suddenly match the filter and have to be touched.
This was detected in bug 864187 comment 76.
Make sure no other periodic filter run is started before the first one finishes.
It looks like this doesn't happen right now as all of TB UI is frozen while a filter is running, but let's make it explicit and safe in the code in case filters start to run async or some threading changes cause the periodic timer fires even when other filter run is ongoing.

Comment 1

[:aceman]

Attachment: 1554387.patch

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9067529 [details] [diff] [review]
1554387.patch

Looks OK to me, let's not forget it for 68.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9067529 [details] [diff] [review]
1554387.patch

Review of attachment 9067529 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 4

[:aceman]

Thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/066da1c827a5
do not start new periodic filter if one is already running. r=mkmelin

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/4c9bfe40671c5470845f361e653b3e2ed35d517e