Closed Bug 1554404 Opened 8 months ago Closed 6 months ago

[remote-dbg-next] Inspect buttons for service workers are disabled without explanation or alternative

Categories

(DevTools :: about:debugging, enhancement, P2)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We were hoping that sw-e10s refactor would land in 68, but it didn't and we didn't update our service worker debugging features.

Right now for most users, the "Inspect" buttons will be disabled, but there is no explanation displayed and no way for users to bypass this.

I am not suggesting we bring back the "disable multi e10s" feature, but maybe we should still let users click on Inspect. In some cases, a new service worker instance might spawn and make the debugging session pointless, but to be honest I've never experienced it. So maybe warning and enabling the buttons would be a good move here?

I wonder if having the warning in about:devtools-toolbox would be better than in about:debugging ?

Priority: -- → P2

We might not ship the refactor in 70 cycle, so let's try to address this here.

As explained in the summary, we have 2 options:

  • keep the "Inspect" buttons disabled and show a warning message in about:debugging, eg "ServiceWorker inspection is unavailable on multiprocess Firefox" (I specify multiprocess, because you won't get the warning when connected to Fennec for instance)
  • enable the "Inspect" buttons and show a warning in about:devtools-toolbox, eg "ServiceWorker debugging is experimental and might not work as expected"

The motivation for option 2 is that while in theory sw debugging is not always working, in practice you can still use it.
It might be incorrect by showing you the wrong instance of the worker but it won't be fully broken.

What do you think Harald?

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Flags: needinfo?(hkirschner)

The DOM team has some confidence to ship in 70, so we could take a bet here and leave it as is.

Related, if we ship SW debugging in the Debugger in 70, how would toolbox be able to handle that or would we keep supporting the existing flow?

Flags: needinfo?(hkirschner)

Thanks for the feedback, although I prefer to still take action now.

The DOM team has some confidence to ship in 70

I would prefer to be careful here. The patches have been under review for 4 months now, and even if they land there is a chance the refactor will be nightly only. I will move forward with option 1 for now.

if we ship SW debugging in the Debugger in 70

I don't have any insights on the progress from the debugger team.
They are waiting for the platform refactor to be done, and I already have my doubts for this to be done in 70.

how would toolbox be able to handle that or would we keep supporting the existing flow?

For now, let's keep things separated.

Attachment #9079707 - Attachment description: Bug 1554404 - Add title to disabled inspect serviceworker buttons in aboutdebugging → Bug 1554404 - Add title to disabled serviceworker buttons in aboutdebugging
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/449f7d704851
Add title to disabled serviceworker buttons in aboutdebugging r=fluent-reviewers,Pike,daisuke
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.