1554539 - access-control-basic-post-with-non-cors-safelisted-content-type.htm should fail because of missing request header

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[(no longer active)]

While running this test, the first fetch of http://w3c-test.org/xhr/resources/access-control-basic-options-not-supported.py fails with:

{"error": {"message": "Traceback (most recent call last):\n  File \"/u/www.w3c-test.org/web-platform-tests/master/tools/wptserve/wptserve/handlers.py\", line 310, in __call__\n    rv = self.func(request, response)\n  File \"/u/www.w3c-test.org/web-platform-tests/master/xhr/resources/access-control-basic-options-not-supported.py\", line 7, in main\n    response.headers.set(\"Access-Control-Allow-Origin\", request.headers.get(\"origin\"))\n  File \"/u/www.w3c-test.org/web-platform-tests/master/tools/wptserve/wptserve/response.py\", line 331, in set\n    value = _maybe_encode(value)\n  File \"/u/www.w3c-test.org/web-platform-tests/master/tools/wptserve/wptserve/response.py\", line 315, in _maybe_encode\n    raise TypeError(\"Unexpected value in ResponseHeaders: %r\" % s)\nTypeError: Unexpected value in ResponseHeaders: None\n", "code": 500}}

This happens because the Origin header is missing on that request. For some reason, when running this test with ./mach wpt the test doesn't fail.

Comment 1

[(no longer active)]

To be clear, the real problem is that the test is trying to detect whether the browser sends the Origin header with POST requests (which we don't) and it fails at doing that.

Comment 2

[(no longer active)]

Attachment: Bug 1554539 - Fix access-control-basic-options-not-supported.py to consistently fail if the Origin header is unexpectedly missing;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7055c90b69dc
Fix access-control-basic-options-not-supported.py to consistently fail if the Origin header is unexpectedly missing; r=jgraham

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17044 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7055c90b69dc

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged