Closed Bug 1554590 Opened 5 years ago Closed 5 years ago

Reminder dialogue starts with items collapsed (TB 68 beta)

Categories

(Calendar :: Dialogs, defect)

Lightning 68
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jorgk-bmo, Assigned: darktrojan)

References

Details

(Keywords: regression)

Attachments

(1 file)

The reminder dialogue starts with the items collapsed, that is:

Description            Today at 8:00

You need to click it to see the buttons, details link, etc. That will be surprising to users.

Keywords: regression
Version: Trunk → Lightning 7.0
Attached patch 1554590-alarm-first-item-1.diff — — Splinter Review

Looks like richlist.selectedIndex doesn't like items that aren't richlistitems.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9070918 - Flags: review?(philipp)
Attachment #9070918 - Flags: approval-calendar-beta?(philipp)
Attachment #9070918 - Flags: review?(philipp)
Attachment #9070918 - Flags: review+
Attachment #9070918 - Flags: approval-calendar-beta?(philipp)
Attachment #9070918 - Flags: approval-calendar-beta+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f6d100d63838
Select first item in alarm dialog. r=philipp

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 7.1
Target Milestone: 7.1 → 7.0

Working on beta 68, thanks.

Status: RESOLVED → VERIFIED

(In reply to Geoff Lankow (:darktrojan) from comment #2)

Looks like richlist.selectedIndex doesn't like items that aren't richlistitems.

Maybe we should make sure they are? What are they?

calendar-alarm-widget.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: