1554614 - [patch] add support for e2k target

Status: VERIFIED FIXED

(NSPR :: NSPR, enhancement)

Description

[Michael Shigorin]

Attachment: 0001-Add-type-definitions-for-Elbrus-architecture.patch

NSPR currently lacks e2k platform support (64-bit Elbrus 2000 architecture); it's not only 4.21 version I've patched but the current hg I've checked the patch to apply against either.

Please find the patch attached.

Comment 1

[Michael Shigorin]

The test suite doesn't quite pass for me, gotta have a closer look at some hanging tests like pipepong; Firefox port with these changes does work as a matter of fact though.

Comment 2

[Michael Shigorin]

Attachment: updated patch for NSPR 4.27/4.28

I've updated the e2k arch support patch for 4.27 (fits current hg either) and ran the testsuite on host this time, not in hasher(7) chroot employing some isolation:

nspr-4.27/nspr/pr/tests$ DYLD_LIBRARY_PATH=../../dist/lib ./accept
PASS
nspr-4.27/nspr/pr/tests$ DYLD_LIBRARY_PATH=../../dist/lib ../../../nspr/pr/tests/runtests.sh ../..

All of those have Passed except timetest:

nspr-4.27/nspr/pr/tests> ./timetest
PR_ParseTimeString() incorrect
t is -1664496000000000, t2 is -1664495981000000, time string is Wed Apr 4 02:31:19 +0231 1917

Is it critical? Looks quite like bug 385748 to me... (I can attach runtests.log collected if needed)

Comment 3

[Michael Shigorin]

PS: the browser built with nspr patched this way actually works for me.

Comment 4

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 9174114 [details] [diff] [review]
updated patch for NSPR 4.27/4.28

Review of attachment 9174114 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right to me. Since I'm not an owner for NSPR though, I'm going to ask Kai's feedback as well.

Comment 5

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nspr/rev/353611bde2596b0bd71f63cdaed271908fb636c6

Comment 6

[Michael Shigorin]

Спасибо, guys!

Comment 7

[Michael Shigorin]

Built hg trunk on e2k, tests ran with no failures:

$ DYLD_LIBRARY_PATH=../../dist/lib ../../../nspr/pr/tests/runtests.sh ../..
/usr/src/RPM/BUILD/nspr/pr/tests

NSPR Test Results - tests

BEGIN Thu Sep 10 22:47:03 UTC 2020
NSPR_TEST_LOGFILE nspr-test.log

Test Result

abstract (22:47:03) Passed
accept (22:47:03) Passed
acceptread (22:47:09) Passed
acceptreademu (22:47:20) Passed
affinity (22:47:30) Passed
alarm (22:47:30) Passed
anonfm (22:48:33) Passed
atomic (22:48:34) Passed
attach (22:48:34) Passed
bigfile (22:48:34) Passed
cleanup (22:48:34) Passed
concur (22:48:39) Passed
cvar2 (22:48:49) Passed
dlltest (22:48:49) Passed
dtoa (22:48:49) Passed
errcodes (22:48:49) Passed
exit (22:48:49) Passed
fdcach (22:48:59) Passed
fileio (22:49:00) Passed
foreign (22:49:00) Passed
formattm (22:49:03) Passed
fsync (22:49:03) Passed
i2l (22:49:03) Passed
initclk (22:49:03) Passed
inrval (22:49:06) Passed
instrumt (22:50:36) Passed
intrio (22:50:37) Passed
intrupt (22:50:57) Passed
io_timeout (22:51:10) Passed
ioconthr (22:51:16) Passed
join (22:51:21) Passed
joinkk (22:51:21) Passed
joinku (22:51:21) Passed
joinuk (22:51:21) Passed
joinuu (22:51:21) Passed
lazyinit (22:51:21) Passed
libfilename (22:51:21) Passed
lltest (22:51:21) Passed
lock (22:51:21) Passed
lockfile (22:52:04) Passed
logger (22:52:14) Passed
many_cv (22:52:24) Passed
ntoh (22:52:24) Passed
op_excl (22:52:24) Passed
op_filnf (22:52:24) Passed
op_filok (22:52:24) Passed
op_nofil (22:52:24) Passed
parsetm (22:52:24) Passed
peek (22:52:24) Passed
perf (22:53:05) Passed
pipeping (22:53:07) Passed
pipeping2 (22:53:07) Passed
pipeself (22:53:07) Passed
poll_nm (22:53:07) Passed
poll_to (22:53:07) Passed
pollable (22:53:12) Passed
prftest (22:53:12) Passed
prfz (22:53:12) Passed
primblok (22:53:12) Passed
prpollml (22:53:12) Passed
pushtop (22:53:33) Passed
randseed (22:53:33) Passed
reinit (22:53:33) Passed
rwlocktest (22:53:33) Passed
sel_spd (22:53:33) Passed
selct_er (22:53:33) Passed
selct_nm (22:53:33) Passed
selct_to (22:53:33) Passed
selintr (22:53:38) Passed
sema (22:53:40) Passed
semaerr (22:53:40) Passed
semaping (22:53:40) Passed
sendzlf (22:53:40) Passed
server_test (22:53:40) Passed
servr_kk (22:53:40) Passed
servr_uk (22:53:40) Passed
servr_ku (22:53:40) Passed
servr_uu (22:53:40) Passed
short_thread (22:53:40) Passed
sigpipe (22:53:40) Passed
sockping (22:53:40) Passed
sprintf (22:53:40) Passed
stack (22:53:41) Passed
stdio (22:53:48) Passed
str2addr (22:53:48) Passed
strod (22:53:48) Passed
switch (22:53:48) Passed
system (22:53:50) Passed
testbit (22:53:50) Passed
testfile (22:53:50) Passed
threads (22:53:50) Passed
timemac (22:53:51) Passed
timetest (22:53:51) Passed
tpd (22:53:56) Passed
udpsrv (22:53:56) Passed
version (22:53:56) Passed
writev (22:53:56) Passed
xnotify (22:53:56) Passed
zerolen (22:53:56) Passed
END Thu Sep 10 22:54:11 UTC 2020