Closed Bug 1554642 Opened 1 year ago Closed 1 year ago

[de-xbl] convert the calendar-category-box binding

Categories

(Calendar :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 69.0

People

(Reporter: mkmelin, Assigned: khushil324)

References

Details

Attachments

(2 files, 1 obsolete file)

Assignee: nobody → khushil324

The gradient color is very light and hard to identify because of the similar background color of calendar-month-day-box-item. Can we change the color of gradient to identify the category type easily?

Attachment #9071201 - Flags: review?(philipp)
Attachment #9071201 - Flags: feedback?(mkmelin+mozilla)
Status: NEW → ASSIGNED

Do you have a screenshot for this?

Flags: needinfo?(khushil324)
Flags: needinfo?(khushil324)
Comment on attachment 9071201 [details] [diff] [review]
Bug-1554642_de-xbl_calendar-category-box.patch

Review of attachment 9071201 [details] [diff] [review]:
-----------------------------------------------------------------

This seems to work the wrong way. It applies the color to all of the event, not just to the (whatever-its-called) category indicator at the right. So if I set vacation to green, the whole event is green and I can't see the text.
Attachment #9071201 - Flags: review?(philipp)
Attachment #9071201 - Flags: feedback?(mkmelin+mozilla)
Attachment #9071201 - Flags: feedback-

(In reply to Magnus Melin [:mkmelin] from comment #4)

This seems to work the wrong way. It applies the color to all of the event,
not just to the (whatever-its-called) category indicator at the right. So if
I set vacation to green, the whole event is green and I can't see the text.

I checked it on Linux as well as Mac. It is working fine. I am editing the color from preferences > Calendar > Categories. Can you share the screenshot?

(In reply to Khushil Mistry [:khushil324] from comment #5)

I checked it on Linux as well as Mac. It is working fine. I am editing the color from preferences > Calendar > Categories. Can you share the screenshot?

It is working fine on Multiweek but not in the week view. I will update the patch.

Attachment #9071201 - Attachment is obsolete: true
Attachment #9073761 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 9073761 [details] [diff] [review]
Bug-1554642_de-xbl_calendar-category-box.patch

Review of attachment 9073761 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine now, thx!
Attachment #9073761 - Flags: review?(philipp)
Attachment #9073761 - Flags: feedback?(mkmelin+mozilla)
Attachment #9073761 - Flags: feedback+
Attachment #9073761 - Flags: review?(philipp) → review+

Khushil, did you have a try run for this? If not, send one off and then get it checked in.

Yeah, sure.

Keywords: checkin-needed

Please repeat this try run, it's all orange due to other reasons.

Keywords: checkin-needed
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4cd00a290f7a
[de-xbl] convert the calendar-category-box binding. r=philipp

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 7.1
You need to log in before you can comment on or make changes to this bug.