1554642 - [de-xbl] convert the calendar-category-box binding

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Magnus Melin [:mkmelin]]

Convert the calendar-category-box binding
https://searchfox.org/comm-central/rev/5a670c59f9004ef9be4874cfbfe57ec2ef3b260f/calendar/base/content/calendar-view-core.xml#382

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1554642_de-xbl_calendar-category-box.patch

The gradient color is very light and hard to identify because of the similar background color of calendar-month-day-box-item. Can we change the color of gradient to identify the category type easily?

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Do you have a screenshot for this?

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Screenshot 2019-06-11 at 2.08.30 PM.png

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9071201 [details] [diff] [review]
Bug-1554642_de-xbl_calendar-category-box.patch

Review of attachment 9071201 [details] [diff] [review]:
-----------------------------------------------------------------

This seems to work the wrong way. It applies the color to all of the event, not just to the (whatever-its-called) category indicator at the right. So if I set vacation to green, the whole event is green and I can't see the text.

Comment 5

[Khushil Mistry [:khushil324]]

(In reply to Magnus Melin [:mkmelin] from comment #4)

This seems to work the wrong way. It applies the color to all of the event,
not just to the (whatever-its-called) category indicator at the right. So if
I set vacation to green, the whole event is green and I can't see the text.

I checked it on Linux as well as Mac. It is working fine. I am editing the color from preferences > Calendar > Categories. Can you share the screenshot?

Comment 6

[Khushil Mistry [:khushil324]]

(In reply to Khushil Mistry [:khushil324] from comment #5)

I checked it on Linux as well as Mac. It is working fine. I am editing the color from preferences > Calendar > Categories. Can you share the screenshot?

It is working fine on Multiweek but not in the week view. I will update the patch.

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: Bug-1554642_de-xbl_calendar-category-box.patch

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9073761 [details] [diff] [review]
Bug-1554642_de-xbl_calendar-category-box.patch

Review of attachment 9073761 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine now, thx!

Comment 9

[Magnus Melin [:mkmelin]]

Khushil, did you have a try run for this? If not, send one off and then get it checked in.

Comment 10

[Khushil Mistry [:khushil324]]

Yeah, sure.

Comment 11

[Khushil Mistry [:khushil324]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=678ff11b94bcd3797bfc183fa10a86f1d040dc63

Comment 12

[Jorg K (CEST = GMT+2)]

Please repeat this try run, it's all orange due to other reasons.

Comment 13

[Khushil Mistry [:khushil324]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6053621fd273332b102d9d51a241500394fe50c5

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4cd00a290f7a
[de-xbl] convert the calendar-category-box binding. r=philipp