1554668 - browser.tabs.warnOnClose = true doesn't warn about closing multiple tabs

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect, P5)

Description

[vstepaniuk]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Close multiple tabs (Close tabs to the right / Close other tabs)

Actual results:

Those multiple tabs are closed.

Expected results:

The warning of closing multiple tabs should have appeared.

Comment 1

[Gingerbread Man]

(In reply to vstepaniuk from comment #0)

Close multiple tabs (Close tabs to the right / Close other tabs)

browser.tabs.warnOnClose which you put in your summary is about warning when about to close the window with multiple tabs open.

The warning of closing multiple tabs should have appeared.

browser.tabs.warnOnCloseOtherTabs is the correct preference name, but it's apparently intentional that it doesn't do anything anymore.

(In reply to (Limited availability 5/20-5/24) Jared Wein [:jaws] (please needinfo? me) from bug 1135303, comment 15)

(In reply to Dão Gottwald [::dao] from bug 1135303, comment 11)

I also wonder if we should just not prompt for close to right / close other
tabs, and remove browser.tabs.warnOnCloseOtherTabs...

Yeah, I think this is the better route.

Why does that preference still exist in a brand new profile, since it actually has no effect now?

Comment 2

[Dão Gottwald [:dao]]

I assume this works as expected after bug 1135303. Jaws, please resolve or re-prioritize as you see fit.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

The browser.tabs.warnOnCloseOtherTabs preference still works, but only prompts when the amount of tabs to close are greater than browser.sessionstore.max_tabs_undo, which defaults to 25.