Closed
Bug 1554707
Opened 5 years ago
Closed 5 years ago
[meta] Refactor existing folder structure in /test
Categories
(DevTools :: Application Panel, task, P1)
DevTools
Application Panel
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: ogasidlo, Assigned: ogasidlo)
References
(Regressed 1 open bug)
Details
(Keywords: meta, Whiteboard: foundation-work)
Attachments
(1 file, 1 obsolete file)
Our folder structure right now for tests is as follows:
test
|_ service-workers (contains mocks + helpers for SW tests)
|_ browser_application_panel_**.js (several test files)
|_ browser. ini
|_ head.js
I suggest aligning the structure with remote debugging as far as possible as we have soon very similar features.
|_ browser
--|_ mocks (move service-workers mocks in here - needs a review of what we need to refactor)
--|_ helpers (move service-workers helpers in here - needs a review of what we need to refactor)
--|_ browser_application_panel_**.js (several test files)
|_ components (new)
--|_ component_application_panel_**.js (new)
|_ unit (new)
--|_ unit_application_panel_**.js (new)
|_ initializer.js (for base urls + require of App.js component)
|_ application.js (require of all modules)
|_ application.css (require of all styles)
|_ index.html
|_ brower.ini
Updated•5 years ago
|
Priority: P3 → P2
Updated•5 years ago
|
Type: defect → task
Keywords: meta
Summary: Refactor existing folder structure in /test → [meta] Refactor existing folder structure in /test
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → ogasidlo
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee | ||
Comment 1•5 years ago
|
||
We need to split the lint file here as well: https://phabricator.services.mozilla.com/D32959#inline-197512
Comment 2•5 years ago
|
||
+1 to this structure (basically what we have in remote debugging plus renaming jest
to components
). We should add this to our doc, so people know how to run every type of tests.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Refactor test folder structure to align with remote debugging
Updated•5 years ago
|
Attachment #9072112 -
Attachment is obsolete: true
Pushed by ogasidlo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c022b93b0777 Refactor test folder structure, r=jdescottes,ladybenko
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/e633c74fdd10 Refactor test folder structure: adjust code for js Prettier. a=eslint-fix CLOSED TREE
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c022b93b0777
https://hg.mozilla.org/mozilla-central/rev/e633c74fdd10
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•