1554755 - The optimization introduced by bug 1367906 is not really sound.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1367906 added an optimization to skip computing border radius of elements without border radii. This bit is only invalidated when the element's style changes, however in the presence of percentage radii that's not all there is to it. The radii also depends on the frame size, for example.

Attachment 9067845 [details] shows an example where we paint a square rather than a circle because this bit is not properly invalidated.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1554755 - Don't set nsIFrame::mMayHaveRoundedCorners to false when there are non-zero percent borders, as we don't track all sizes that are passed to this function. r=mattwoodrow

I think most of the sizes that get here are going to be equivalent to
mRect.Size(), but that seems really hard to prove.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c1c939712a6
Don't set nsIFrame::mMayHaveRoundedCorners to false when there are non-zero percent borders, as we don't track all sizes that are passed to this function. r=mattwoodrow

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17092 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9c1c939712a6

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged