1554843 - Cannot use ATOK Moji Pallet until typing first character even after fixing bug 1549930

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is old regression at 57 (due to bug 1349255), but we should fix this on 68 for ESR and Thunderbird users who use ATOK or some other a11y tools which inputs text into inactive window.

When user moves focus to an editable content in a content process, it posts IME-focus notification to the main process. Then, when the main process prepares IME/keyboard handling in editable content, it posts back IME notification requests to the content process. Then, the content process's PuppetWidget modifies its IME notification requests, but not modifying cache of IME notification requests in its TextEventDispatcher. Therefore, IMEContentObserver keep referring older IME notification requests which are initialized without IME-focus (FYI: IMEContentObserver caches the reference of cached IME notification requests in TextEventDispatcher. So, we need to refresh only the cache of IME notification requests in TextEventDispatcher).

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1554843 - Make PuppetWidget::NotifyIMEOfFocusChange() notify TextEventDispatcher of IME notification requests change

When user moves focus to an editable content in a content process, it posts
IME-focus notification to the main process. Then, when the main process
prepares IME/keyboard handling in editable content, it posts back IME
notification requests to the content process. Then, the content process's
PuppetWidget modifies its IME notification requests, but not modifying
cache of IME notification requests in its TextEventDispatcher. Therefore,
IMEContentObserver keep referring older IME notification requests which are
initialized without IME-focus. Note that IMEContentObserver caches the
reference of cached IME notification requests in TextEventDispatcher.
So, we need to refresh only the cache of IME notification requests in
TextEventDispatcher.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0553541318c4
Make PuppetWidget::NotifyIMEOfFocusChange() notify TextEventDispatcher of IME notification requests change r=m_kato

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0553541318c4

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval if you want it to be considered for 68.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, once bug 1549930 is fixed in beta, I'll do that. Otherwise, it does not worthwhile to uplift this.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9068001 [details]
Bug 1554843 - Make PuppetWidget::NotifyIMEOfFocusChange() notify TextEventDispatcher of IME notification requests change

Beta/Release Uplift Approval Request

• User impact if declined: ATOK users cannot input unusual characters from its virtual keyboard called "Moji pallet" even after uplifting bug 1549930. Note that there might be similar a11y tools or something which steals focus and inputting text into last active window.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1549930
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just makes PuppetWidget notify its TextEventDispatcher of changing IME focused widget.
• String changes made/needed: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9068001 [details]
Bug 1554843 - Make PuppetWidget::NotifyIMEOfFocusChange() notify TextEventDispatcher of IME notification requests change

ime fix for 68.0b12

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8165ade66edf