1554867 - Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P5)

Description

[Patrick Brosset <:pbro>]

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fdebugger%2Fsrc%2Fworkers%2Fparser%2FgetSymbols.js

Comment 1

[Eugene Simakin]

Hi!
Can I take this one?

Comment 2

[Eugene Simakin]

Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable-next-line+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fdebugger%2Fsrc%2Fworkers%2Fparser%2FgetSymbols.js (the above one is not working)

Comment 3

[Jason Laster [:jlast]]

https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/workers/parser/getSymbols.js

Comment 4

[nightwarriorftw]

Hi Jason,
If anyone is currently not working on this bug, I would like to take this.

Comment 5

[Shrey Gupta]

Hi Jason, I would like to start contributing to this bug.

Comment 6

[Jason Laster [:jlast]]

Hi, sorry for the slow replies. Given two of you requested it, nightwarrior-xxx should probably pick it up.

Comment 7

[nightwarriorftw]

Attachment: Bug 1554867 - Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity, r=jlast

Comment 8

[nightwarriorftw]

Attachment: Bug 1554867 - Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity, r=jlast

---

Comment 9

[nightwarriorftw]

Attachment: Bug 1554867 - Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity, r=jlast

Comment 10

[nightwarriorftw]

Attachment: Bug 1554867 - Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity, r=jlast

---

Comment 11

[nightwarriorftw]

Attachment: Bug 1554867 - Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity, r=jlast

---

---

Comment 12

[nightwarriorftw]

Attachment: Bug 1554867 - Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity, r=jlast

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

nightwarriorftw, are you still interested in fixing this bug?

Honza

Comment 14

[nightwarriorftw]

Hello Honza,
Yes, I had pushed the changes but no-one reviewed. Please review the last patch I had pushed. I have abandoned the previous patches.

Thanks

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 16

[F3n67u]

Attachment: Bug 1554867: Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity r=nchevobbe

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53d031be6a96
Simplify devtools/client/debugger/src/workers/parser/getSymbols.js and remove eslint-disable complexity r=nchevobbe

Comment 18

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/53d031be6a96