1554882 - Simplify devtools/client/netmonitor/src/components/SecurityPanel.js and remove eslint-disable complexity

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P3)

Description

[Patrick Brosset <:pbro>]

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Fcomponents%2FSecurityPanel.js

Comment 1

[Arun Kumar Mohan]

I am on it.

Comment 2

[Arun Kumar Mohan]

Attachment: Bug 1554882 - Refactor SecurityPanel component to remove disabled complexity eslint rule. r=pbro

Comment 3

[Arun Kumar Mohan]

(In reply to Patrick Brosset <:pbro> from comment #0)

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Fcomponents%2FSecurityPanel.js

Hey Patrick, I took a stab at refactoring the SecurityPanel component and this is what I came up with. Looking forward to your feedback.

Thanks in advance!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45491c6288aa
Refactor SecurityPanel component to remove disabled complexity eslint rule. r=Honza

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/45491c6288aa