Closed Bug 1554882 Opened 6 months ago Closed 3 months ago

Simplify devtools/client/netmonitor/src/components/SecurityPanel.js and remove eslint-disable complexity

Categories

(DevTools :: Netmonitor, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: pbro, Assigned: arunmohandm)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Fcomponents%2FSecurityPanel.js

Component: General → Netmonitor
Keywords: good-first-bug
Priority: -- → P3

I am on it.

(In reply to Patrick Brosset <:pbro> from comment #0)

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Fcomponents%2FSecurityPanel.js

Hey Patrick, I took a stab at refactoring the SecurityPanel component and this is what I came up with. Looking forward to your feedback.

Thanks in advance!

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45491c6288aa
Refactor SecurityPanel component to remove disabled complexity eslint rule. r=Honza
Assignee: nobody → arunmohandm
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.