Simplify devtools/client/netmonitor/src/components/SecurityPanel.js and remove eslint-disable complexity
Categories
(DevTools :: Netmonitor, task, P3)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: pbro, Assigned: arunmohandm)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false®exp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Fcomponents%2FSecurityPanel.js
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I am on it.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #0)
This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false®exp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Fcomponents%2FSecurityPanel.js
Hey Patrick, I took a stab at refactoring the SecurityPanel
component and this is what I came up with. Looking forward to your feedback.
Thanks in advance!
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45491c6288aa Refactor SecurityPanel component to remove disabled complexity eslint rule. r=Honza
Comment 5•3 years ago
|
||
bugherder |
Description
•