Simplify devtools/client/netmonitor/src/reducers/requests.js and remove eslint-disable complexity
Categories
(DevTools :: Netmonitor, task, P3)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: pbro, Assigned: arunmohandm)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false®exp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Freducers%2Frequests.js
|
Reporter | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #0)
This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false®exp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Freducers%2Frequests.js
Hey Patrick, I have refactored the code you mentioned and removed the temporarily disabled eslint rule. I have requested you review on my revision. Take a look when you get a chance and let me know if there are any changes to make.
Thanks!
Pushed by aciure@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a1a438c807e Refactor requests reducer to remove disabled complexity eslint rule. r=pbro
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•