Closed Bug 1554883 Opened 6 months ago Closed 4 months ago

Simplify devtools/client/netmonitor/src/reducers/requests.js and remove eslint-disable complexity

Categories

(DevTools :: Netmonitor, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: pbro, Assigned: arunmohandm)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Freducers%2Frequests.js

Component: General → Netmonitor
Keywords: good-first-bug
Priority: -- → P3

(In reply to Patrick Brosset <:pbro> from comment #0)

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Freducers%2Frequests.js

Hey Patrick, I have refactored the code you mentioned and removed the temporarily disabled eslint rule. I have requested you review on my revision. Take a look when you get a chance and let me know if there are any changes to make.

Thanks!

Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a1a438c807e
Refactor requests reducer to remove disabled complexity eslint rule. r=pbro
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → arunmohandm
You need to log in before you can comment on or make changes to this bug.