Closed Bug 1554884 Opened 6 months ago Closed 3 months ago

Simplify devtools/client/netmonitor/src/utils/filter-text-utils.js and remove eslint-disable complexity

Categories

(DevTools :: Netmonitor, task, P3)

Product:
DevTools
Component:
Netmonitor
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: pbro, Assigned: arunmohandm)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1554884 - Refactor isFlagFilterMatch function to remove disabled complexity eslint rule. r=pbro
47 bytes, text/x-phabricator-request
Details | Review

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fnetmonitor%2Fsrc%2Futils%2Ffilter-text-utils.js

Component: General → Netmonitor
Keywords: good-first-bug
Priority: -- → P3

Just NI myself

Honza

Flags: needinfo?(odvarko)

Review comments posted
Honza

Flags: needinfo?(odvarko)
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12374bb26e7b
Refactor isFlagFilterMatch function to remove disabled complexity eslint rule. r=Honza

https://hg.mozilla.org/mozilla-central/rev/12374bb26e7b

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → arunmohandm
You need to log in before you can comment on or make changes to this bug.