Closed Bug 1554887 Opened 3 years ago Closed 2 months ago

Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity

Categories

(DevTools :: Debugger, task, P5)

task

Tracking

(firefox102 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: pbro, Assigned: F3n67u)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fshared%2Fcomponents%2FFrame.js

Component: General → Debugger
Keywords: good-first-bug
Priority: -- → P5

I would like to take this one.

Are the instructions at https://docs.firefox-dev.tools/ the ones I should follow to submit a patch?

Flags: needinfo?(jlaster)

Yes, thanks Kenji. Sorry for the delayed reaction

Flags: needinfo?(jlaster)

Hey, can I work on this !?

hey,

we fixed this issue and put in a pull request: https://github.com/mozilla/gecko-dev/pull/512

are you able to check it out and let us know if there are any problems.

Thanks.

Flags: needinfo?(pbrosset)

Hi. I see Logan already replied in the PR, but I'll repeat it here in case other people are wondering if Mozilla accepts PRs on github: no, it doesn't. This gecko-dev repostitory is only a one-way mirror of the mercurial mozilla repository. It's useful for many different things, but it does not allow changes directly on github and is never synced back to mercurial.
In order to contribute to the mozilla code base, you need to follow this guide: https://firefox-source-docs.mozilla.org/contributing/index.html

Flags: needinfo?(pbrosset)
Assignee: nobody → ramya.praneetha04
Status: NEW → ASSIGNED

Sorry, I'm not the best person to review this change right now. Thanks a lot for working on it though.
I think the people who might know this code best are probably @nchevobbe or @jlast . Can you please ask them for review instead?

Flags: needinfo?(ramya.praneetha04)

@pbro - Yeah sure, thank you

Flags: needinfo?(ramya.praneetha04)
Attachment #9134907 - Attachment description: Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=pbro → Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=nchevobbe, jlast
Attachment #9134907 - Attachment description: Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=nchevobbe, jlast → Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=pbro
Attachment #9134907 - Attachment description: Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=pbro → Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=nchevobbe, jlast

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: ramya.praneetha04 → nobody
Status: ASSIGNED → NEW

may I take this issue?

Assigned to you, thank you for helping.

Assignee: nobody → F3n67u
Status: NEW → ASSIGNED
Attachment #9274020 - Attachment description: Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity r=nchevobbe → Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=nchevobbe
Attachment #9274020 - Attachment description: Bug 1554887: Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity. r=nchevobbe → Bug 1554887 - [devtools] Remove eslint-disable complexity in devtools/client/shared/components/Frame.js. r=nchevobbe
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e34b82eceb56
[devtools] Remove eslint-disable complexity in devtools/client/shared/components/Frame.js. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.