Simplify devtools/client/shared/components/Frame.js and remove eslint-disable complexity
Categories
(DevTools :: Debugger, task, P5)
Tracking
(firefox102 fixed)
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: pbro, Assigned: F3n67u)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false®exp=false&path=devtools%2Fclient%2Fshared%2Fcomponents%2FFrame.js
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
I would like to take this one.
Are the instructions at https://docs.firefox-dev.tools/ the ones I should follow to submit a patch?
|
|
||
Updated•5 years ago
|
|
||
Comment 3•4 years ago
|
||
Hey, can I work on this !?
hey,
we fixed this issue and put in a pull request: https://github.com/mozilla/gecko-dev/pull/512
are you able to check it out and let us know if there are any problems.
Thanks.
|
|
Reporter | |
Comment 5•4 years ago
|
||
Hi. I see Logan already replied in the PR, but I'll repeat it here in case other people are wondering if Mozilla accepts PRs on github: no, it doesn't. This gecko-dev repostitory is only a one-way mirror of the mercurial mozilla repository. It's useful for many different things, but it does not allow changes directly on github and is never synced back to mercurial.
In order to contribute to the mozilla code base, you need to follow this guide: https://firefox-source-docs.mozilla.org/contributing/index.html
|
||
Comment 6•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Reporter | |
Comment 7•4 years ago
|
||
Sorry, I'm not the best person to review this change right now. Thanks a lot for working on it though.
I think the people who might know this code best are probably @nchevobbe or @jlast . Can you please ask them for review instead?
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Comment 9•3 years ago
|
||
This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
|
Assignee | |
Comment 10•2 years ago
|
||
may I take this issue?
|
||
Comment 11•2 years ago
|
||
Assigned to you, thank you for helping.
|
|
Assignee | |
Comment 12•2 years ago
|
||
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Comment 13•2 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e34b82eceb56 [devtools] Remove eslint-disable complexity in devtools/client/shared/components/Frame.js. r=nchevobbe
|
||
Comment 14•2 years ago
|
||
| bugherder | ||
Description
•