Simplify devtools/client/shared/source-utils.js and remove eslint-disable complexity
Categories
(DevTools :: Debugger, task, P5)
Tracking
(firefox75 fixed)
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: pbro, Assigned: aarushivij)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false®exp=false&path=devtools%2Fclient%2Fshared%2Fsource-utils.js
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Hi, Can I take this bug? This will be my first contribution (:
Comment 2•5 years ago
|
||
Go for it
Comment 3•5 years ago
|
||
Thanks I will start working on this
Comment 4•5 years ago
|
||
Hi, sorry for not updating I have been busy at work. Quick Question is there a reason why this code was written this way? Instead of maybe using startsWith() or using an auxiliary function?
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
Hello! :)
I'm wondering what's next after sending the code review. Let me know if I'm still missing something.
Have a great day!
Comment 7•5 years ago
|
||
Hi, sorry. we were traveling last week. I'll review shortly
Assignee | ||
Comment 8•4 years ago
|
||
Hello
Can I take this issue?
Aarushi :)
Assignee | ||
Comment 9•4 years ago
|
||
Also the link mentioned in comment1 does show any file.
Can you please guide through the issue
Thanks
Reporter | ||
Comment 10•4 years ago
|
||
Thank you for your interest. I've assigned the bug to you now.
You are right, the link has expired. Here's the exact line that we want to remove: https://searchfox.org/mozilla-central/rev/3a0a8e2762821c6afc1d235b3eb3dde63ad3b01a/devtools/client/shared/source-utils.js#259
The idea is to simplify the code in that function so that ESLint does not warn about the function being too complex anymore, so that we can remove the comment.
Assignee | ||
Comment 11•4 years ago
|
||
Thanks Patrick for assigning to me.
Shall get back to you soon.
Aarushi Vij
Assignee | ||
Comment 12•4 years ago
|
||
Comment 13•4 years ago
|
||
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a423e28bd0fb Simplify devtools/client/shared/source-utils.js and remove eslint-disable complexity r=pbro
Comment 14•4 years ago
|
||
bugherder |
Description
•