Closed Bug 1554901 Opened 6 years ago Closed 6 years ago

Simplify devtools/client/webconsole/components/ReverseSearchInput.js and remove eslint-disable complexity

Categories

(DevTools :: Console, task, P2)

Product:
DevTools
Component:
Console
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: pbro, Assigned: arunmohandm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1554901 - Refactor onInputKeyDown method to remove disabled complexity eslint rule. r=nchevobbe
47 bytes, text/x-phabricator-request
Details | Review

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fclient%2Fwebconsole%2Fcomponents%2FReverseSearchInput.js

Component: General → Console
Priority: -- → P2
Assignee: nobody → arunmohandm
Status: NEW → ASSIGNED
Attachment #9080879 - Attachment description: Bug 1554901 - Refactor Message component to remove disabled complexity eslint rule. r=nchevobbe → Bug 1554901 - Refactor Message component to remove disabled complexity eslint rule. r=pbro
Attachment #9080879 - Attachment description: Bug 1554901 - Refactor Message component to remove disabled complexity eslint rule. r=pbro → Bug 1554901 - Refactor ReverseSearchInput component to remove disabled complexity eslint rule. r=pbro

Depends on D39488

Attachment #9080879 - Attachment description: Bug 1554901 - Refactor ReverseSearchInput component to remove disabled complexity eslint rule. r=pbro → Bug 1554901 - Refactor onInputKeyDown method to remove disabled complexity eslint rule. r=nchevobbe
Attachment #9081074 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4fa1ea22250 Refactor onInputKeyDown method to remove disabled complexity eslint rule. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/b4fa1ea22250

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: