Closed
Bug 1554913
Opened 7 years ago
Closed 6 years ago
Simplify devtools/server/actors/network-monitor/network-observer.js and remove eslint-disable complexity
Categories
(DevTools :: Netmonitor, task, P3)
DevTools
Netmonitor
Tracking
(firefox73 fixed)
RESOLVED
FIXED
Firefox 73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: pbro, Assigned: ksenia)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false®exp=false&path=devtools%2Fserver%2Factors%2Fnetwork-monitor%2Fnetwork-observer.js
| Reporter | ||
Updated•7 years ago
|
Component: General → Netmonitor
Updated•7 years ago
|
Keywords: good-first-bug
Priority: -- → P3
| Assignee | ||
Comment 1•6 years ago
|
||
I would like to work on this
| Assignee | ||
Updated•6 years ago
|
Assignee: nobody → kberezina
Comment 2•6 years ago
|
||
Thanks for helping with the cleanup!
Honza
| Assignee | ||
Comment 3•6 years ago
|
||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48295741798b
Remove eslint-disable-next-line complexity from _setupHarTimings r=Honza
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in
before you can comment on or make changes to this bug.
Description
•