Closed Bug 1554913 Opened 5 years ago Closed 5 years ago

Simplify devtools/server/actors/network-monitor/network-observer.js and remove eslint-disable complexity

Categories

(DevTools :: Netmonitor, task, P3)

Product:
DevTools
Component:
Netmonitor
Type:
task

Tracking

(firefox73 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: pbro, Assigned: ksenia)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1554913 - Remove eslint-disable-next-line complexity from _setupHarTimings
47 bytes, text/x-phabricator-request
Details | Review

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fserver%2Factors%2Fnetwork-monitor%2Fnetwork-observer.js

Component: General → Netmonitor

I would like to work on this

Assignee: nobody → kberezina

Thanks for helping with the cleanup!

Honza

Status: NEW → ASSIGNED
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48295741798b
Remove eslint-disable-next-line complexity from _setupHarTimings r=Honza

https://hg.mozilla.org/mozilla-central/rev/48295741798b

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: