1554914 - Simplify devtools/server/actors/object.js and remove eslint-disable complexity

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P5)

Description

[Patrick Brosset <:pbro>]

This file contains a special eslint comment to temporarily disable the complexity eslint rule since it contains one or more functions that exceed the maximum complexity threshold. The code should be simplified, and the comment removed. Link to the code in question: https://searchfox.org/mozilla-central/search?q=eslint-disable+complexity&case=false&regexp=false&path=devtools%2Fserver%2Factors%2Fobject.js

Comment 1

[Suhail Singh Bains]

Hi, can I please work on this?

temporarily disable the complexity eslint

Also, how can I check if the complexity of eslint is not difficult.
Thanks

Comment 2

[u648978]

I've checked that eslint-disable complexity is not being used anymore, but eslint-disable-next-line complexity is, so is this issue still open? Can I work on it?

Comment 3

[Patrick Brosset <:pbro>]

You are right, the eslint flag was changed after I opened this bug.
The correct link to the code should now be https://searchfox.org/mozilla-central/rev/96f1457323cc598a36f5701f8e67aedaf97acfcf/devtools/server/actors/object.js#419
This issue is still open and you are more than welcome to work on it!
I'm assigning it to you now. Please do take a look at our contribution documentation if you haven't done so yet: https://docs.firefox-dev.tools

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Mari, are you still interested in this bug? Do you need any help?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 6

[Anurag Kalia :anuragkalia]

Hi Jan, can I work on it? This seems to be something within my reach.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigned to you, thank you.

Honza

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 9

[Shushanik]

Can I work on it?

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, please. Assigned to you.
Honza

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 12

[F3n67u]

Attachment: Bug 1554914 Simplify devtools/server/actors/object.js and remove eslint-disable complexity r=jdescottes

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0c2b6a07153
Simplify devtools/server/actors/object.js and remove eslint-disable complexity r=jdescottes

Comment 14

[F3n67u]

Hi Jan, I already landed a patch. please closed this bug.

Comment 15

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c0c2b6a07153