Open Bug 1554939 Opened 6 years ago Updated 3 years ago

Leverage Uptake Telemetry for errors in Remote Settings "sync" event handlers

Categories

(Core :: Security: PSM, enhancement, P2)

Product:
Core
Component:
Security: PSM
Type:
enhancement

Tracking

()

People

(Reporter: leplatrem, Unassigned)

Details

(Whiteboard: [psm-backlog])

In OneCRL and Pinning clients, the errors are swallowed and the errors are not reported to Telemetry (a comment says that Bug 1254099 will take care of this but it was never done).

https://searchfox.org/mozilla-central/rev/ddb81c7a43ffada1f6cb4200c4f625e50e44dcf3/services/common/blocklist-clients.js#132-137

https://searchfox.org/mozilla-central/rev/ddb81c7a43ffada1f6cb4200c4f625e50e44dcf3/services/common/blocklist-clients.js#177-181

Instead of try/catch we should let the event handler throw the exception.
It will be caught by the Remote Settings calling code, and a Telemetry event (APPLY_ERROR) will be reported.

https://searchfox.org/mozilla-central/rev/ddb81c7a43ffada1f6cb4200c4f625e50e44dcf3/services/settings/RemoteSettingsClient.jsm#397-402

Priority: -- → P2
Whiteboard: [psm-backlog]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.