1554961 - The “Add Top Site” and “Add Search Engine” context menu options do not open their respective modals when clicked if the Top Sites section is collapsed

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Remus Dranca [rdranca], Ecosystem QA]

Attachment: TopSitesCollapsed.gif

[Affected versions]:

• Firefox Release 67.0 and above

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Open the browser with a new profile and navigate to the about:newtab page.
2. Click the Top Sites section title.
3. Click the three dot menu from the "Top sites" section.
4. Observe the "Add Top Site" and "Add Search Engine" options.
5. Click the "Add Top Site" or "Add Search Engine" option and observe the behavior.

[Expected result]:

• Step 4: The "Add Top Site" and "Add Search Engine" options are grayed out.

OR

• Step 4: The two options are actionable.
• Step 5: The "Top sites" section is expanded and the "New Top Site" or "Add Search Engine" modal is displayed.

[Actual result]:

• Step 4: The "Add Top Site" and "Add Search Engine" options are actionable.
• Step 5: The "Top sites" section remains collapsed and the "New Top Site" or "Add Search Engine" modal is not displayed.

[Notes]:

• If the "Top sites" section is expanded after the "Add Top Site" or "Add Search Engine" option is clicked when the section is collapsed, the "New Top Site" and "Add Search Engine" modals are displayed. If both options are selected, both windows are displayed, one after another after canceling/saving the first one.
• Attached is a screen recording of the issue.

Comment 1

[Jeane Carlos]

Which expected result is best? From above when the TopSites section is collapsed.

Step 4: The "Add Top Site" and "Add Search Engine" options are grayed out.
or
Step 4: The two options are actionable.
Step 5: The "Top sites" section is expanded and the "New Top Site" or "Add Search Engine" modal is displayed.

Comment 2

[Wolasi :wolasi]

I'm leaning towards Step 5 because it provides visual confirmation that the top site has been added.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5186

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/16d1399f602c

Comment 5

[Remus Dranca [rdranca], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (70.0a1 Build ID - 20190721215935) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5.

Comment 6

[(Out Sep 17-23) Ryan VanderMeulen]

Is this something we should consider uplifting to Beta for Fx69 or can it ship with Fx70? Please nominate this for Beta approval if you wish to backport.

Comment 7

[Jeane Carlos]

Nope, should be fine to just ship this in FX70