1555020 - Firefox closes itself whenever I click the "X" button on the find bar

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[Sean Feng [:sefeng211]]

By using mozregression, this patch seems to be the problem.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0765f0fa75605655beb1eb98afc7584364efb846&tochange=a9b24ae04ca3684c286b4c8504d694b2426f255c

Comment 1

[Connor Sheehan [:sheehan]]

I'm also seeing this.

Comment 2

[Sean Feng [:sefeng211]]

hey Ehsan, can you see the problem here?

Comment 3

[:Gijs (he/him)]

https://hg.mozilla.org/integration/autoland/rev/a9b24ae04ca3684c286b4c8504d694b2426f255c#l24.12

-      <toolbarbutton anonid="find-closebutton" class="findbar-closebutton close-icon" data-l10n-id="findbar-find-button-close" oncommand="close();" />
+      <toolbarbutton anonid="find-closebutton" class="findbar-closebutton close-icon" data-l10n-id="findbar-find-button-close" oncommand="window.close();" />

That'd be it. Before, it called the close method on the Findbar class, and now it calls window.close() :-\

AFAICT this particular change just needs reverting, but it's probably also worth checking the other changes in the patch...

Comment 5

[(no longer active)]

Attachment: Bug 1555020 - Make sure closing the findbar doesn't close the entire window;

Comment 6

[(no longer active)]

(In reply to :Gijs (he/him) from comment #3)

https://hg.mozilla.org/integration/autoland/rev/a9b24ae04ca3684c286b4c8504d694b2426f255c#l24.12

-      <toolbarbutton anonid="find-closebutton" class="findbar-closebutton close-icon" data-l10n-id="findbar-find-button-close" oncommand="close();" />
+      <toolbarbutton anonid="find-closebutton" class="findbar-closebutton close-icon" data-l10n-id="findbar-find-button-close" oncommand="window.close();" />

That'd be it. Before, it called the close method on the Findbar class, and now it calls window.close() :-\

AFAICT this particular change just needs reverting, but it's probably also worth checking the other changes in the patch...

I tested the rest manually just now and I don't believe any of the other ones are similarly affected.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a6407ed181
Make sure closing the findbar doesn't close the entire window; r=mossop

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/91a6407ed181

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 69.0a1 (2019-05-29), so I'm marking this bug as VERIFIED.