1555022 - Remove unused methods on the Thread Actor

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

I think the following methods of the thread actor are not used and should be removed:

• _requestFrame
• createProtocolCompletionValue
• everything related to the "threadGrips" request

Comment 1

[Shivam Singhal [ :championshuttler ]]

Hi Julian,

I would like to work on it, can i take this up?

Comment 2

[Julian Descottes [:jdescottes]]

Hi Shivam,

Thanks for proposing to work on this, assigning the bug to you!

I see you have already fixed several bugs in DevTools, so I will just add some pointers for what should be removed. The actor thread can be found at https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js and you can simply remove _requestFrame and createProtocolCompletionValue from the file.

To cleanup the "threadGrips" request, it involves a few more files. The request handler in the actor is called onThreadGrips. And then we also need to remove the threadGrips request from the specs (devtools/shared/specs/thread.js) and from our deprecated-thread-client (devtools/shared/client/deprecated-thread-client.js)

Don't hesitate to ping me if you have any question.

Comment 3

[Patrick Brosset <:pbro>]

Hi Shivam, I was wondering if you were still interested in working on this bug? If not, please let me know so this bug can be made available to others.

Comment 4

[Shivam Singhal [ :championshuttler ]]

Hi Patrick, yes working on it!

Comment 5

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1555022 - Remove unused methods on the Thread Actor. r=jdescottes,jlast

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b473a267e85e
Remove unused methods on the Thread Actor. r=jdescottes,jlast

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b473a267e85e