1555083 - [Translate.Next] After submitting a suggestion or translation, the machinery tab still uses the previous strings

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Francesco Lodolo [:flod]]

Attachment: immagine.png

1. Enable "Make suggestions", make sure you're on the "MACHINERY" tab.
2. Submit a suggestion for a string. I clicked on one of the items available in the MACHINERY tab, and pressed enter.
3. The focus moves on the next string, but the machinery is looking for suggestions for the previous string (the one I just submitted).

Comment 1

[Francesco Lodolo [:flod]]

Weird detail:

• After submitting the first string, the one after is reusing the wrong source for machinery.
• If I translate and move to a third string, this one is correct.

Comment 2

[Matjaz Horvat [:mathjazz]]

Findings:

1. After translation is submitted, Machinery makes two requests: one that takes translated string as input (wrong) and one that takes the next one (correct). The latter request is made later, so it appears under the results for the former one.

2. Duplicate requests are also made for the History and Locales tab, but for some reason only results for the next string appear in the tabs.

3. Requests are only duplicated on Save/Suggest actions, but not on Approval.

A fix would be to unify the behaviour with History and Locales tab.

A proper fix would be to only make the requests when necessary.

Comment 3

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

This happened to me for the History tab too. After submitting a suggestion in the "restore-logins-extension" project, I saw it appear in the History tab for the next still untranslated string. I would bet on some race condition there and that the Machinery tab is more prone to the issue as it loads data also from external source like MS terminology and Google translate.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1332

Comment 5

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/674aa6f3674e35ee5d292c8dbf567f880abe8d91