1555109 - Assertion failure: (detail::IsInBounds<From, To>(aFrom)), at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Casting.h:208

Status: NEW

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Found while fuzzing mozilla-central rev 5cc220ddf028.

Assertion failure: (detail::IsInBounds<From, To>(aFrom)), at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Casting.h:208

rax = 0x0000564a86614e40   rdx = 0x0000000000000000
rcx = 0x00007f30b850f324   rbx = 0x00007f30ab44c4a0
rsi = 0x00007f30c46668b0   rdi = 0x00007f30c4665680
rbp = 0x00007fffbbd1e020   rsp = 0x00007fffbbd1e020
r8 = 0x00007f30c46668b0    r9 = 0x00007f30c57d0740
r10 = 0x0000000000000000   r11 = 0x0000000000000000
r12 = 0x0000000000000000   r13 = 0x00007fffbbd1e178
r14 = 0x00007f309d65f000   r15 = 0x00007f30c4078050
rip = 0x00007f30b51e4b7c
OS|Linux|0.0.0 Linux 4.18.0-17-generic #18~18.04.1-Ubuntu SMP Fri Mar 15 15:27:12 UTC 2019 x86_64
CPU|amd64|family 6 model 94 stepping 3|1
GPU|||
Crash|SIGSEGV|0x0|0
0|0|libxul.so|unsigned char mozilla::AssertedCast<unsigned char, int>(int)|hg:hg.mozilla.org/mozilla-central:mfbt/Casting.h:5cc220ddf028de011a922042ee9ba691b94d055d|208|0x16
0|1|libxul.so|mozilla::WebGLFBAttachPoint::Set(mozilla::gl::GLContext*, mozilla::webgl::FbAttachInfo const&)|hg:hg.mozilla.org/mozilla-central:dom/canvas/WebGLFramebuffer.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|62|0x9
0|2|libxul.so|mozilla::WebGLFramebuffer::FramebufferAttach(unsigned int, mozilla::webgl::FbAttachInfo const&)|hg:hg.mozilla.org/mozilla-central:dom/canvas/WebGLFramebuffer.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|1152|0x12
0|3|libxul.so|mozilla::WebGLContext::FramebufferAttach(unsigned int, unsigned int, StrongGLenum<TexTargetDetails>, mozilla::webgl::FbAttachInfo const&) const|hg:hg.mozilla.org/mozilla-central:dom/canvas/WebGLContextGL.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|555|0xf
0|4|libxul.so|mozilla::WebGLContext::FramebufferTextureLayer(unsigned int, unsigned int, mozilla::WebGLTexture*, int, int) const|hg:hg.mozilla.org/mozilla-central:dom/canvas/WebGLContextGL.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|631|0x20
0|5|libxul.so|mozilla::dom::WebGL2RenderingContext_Binding::framebufferTextureLayer|s3:gecko-generated-sources:90b93dcfa3b6b537431dd00a3094e076c879e16b0f29d3966016a0cd628ba3d9818096e001a721987ed730c4b3d17ca12b5b268b5ca9601ff9da7062b2934e79/dom/bindings/WebGL2RenderingContextBinding.cpp:|1443|0x1a
0|6|libxul.so|bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*)|hg:hg.mozilla.org/mozilla-central:dom/bindings/BindingUtils.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|3165|0x24
0|7|libxul.so|CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), JS::CallArgs const&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|448|0x16
0|8|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|540|0x12
0|9|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|595|0xd
0|10|libxul.so|Interpret|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|599|0x13
0|11|libxul.so|js::RunScript(JSContext*, js::RunState&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|425|0xb
0|12|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|568|0xf
0|13|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|595|0xd
0|14|libxul.so|js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|611|0x5
0|15|libxul.so|JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>)|hg:hg.mozilla.org/mozilla-central:js/src/jsapi.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|2654|0x1c
0|16|libxul.so|mozilla::dom::EventListener::HandleEvent(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&)|s3:gecko-generated-sources:9ca8646d8042e9b4b76d2e1b358b984be17743b71b832c0897d61bb500e0fecbe38fa54273dc522878c87fcb2c9bfd274a8190c7bc56fbbb58cb3ca68462e527/dom/bindings/EventListenerBinding.cpp:|52|0x5
0|17|libxul.so|void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*)|s3:gecko-generated-sources:f3d9c01258576daaac3afc4fb3b283652e7f1168abb5287eff6775451ebd0ab6a0e4c8d88d3a67f7147042501bc091c6dfed25b4b8ccf4e4f420897b8d0ba906/dist/include/mozilla/dom/EventListenerBinding.h:|66|0x1c
0|18|libxul.so|mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*)|hg:hg.mozilla.org/mozilla-central:dom/events/EventListenerManager.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|1036|0x1e
0|19|libxul.so|mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool)|hg:hg.mozilla.org/mozilla-central:dom/events/EventListenerManager.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|1236|0x19
0|20|libxul.so|mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|351|0x6
0|21|libxul.so|mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|551|0x12
0|22|libxul.so|mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|1048|0x1a
0|23|libxul.so|mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|1148|0x19
0|24|libxul.so|nsINode::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&)|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|1030|0x5
0|25|libxul.so|nsContentUtils::DispatchEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, mozilla::Trusted, bool*, mozilla::ChromeOnlyDispatch)|hg:hg.mozilla.org/mozilla-central:dom/base/nsContentUtils.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|3947|0x30
0|26|libxul.so|nsContentUtils::DispatchTrustedEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, bool*)|hg:hg.mozilla.org/mozilla-central:dom/base/nsContentUtils.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|3918|0x19
0|27|libxul.so|mozilla::dom::Document::DispatchContentLoadedEvents()|hg:hg.mozilla.org/mozilla-central:dom/base/Document.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|5054|0x40
0|28|libxul.so|mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.h:5cc220ddf028de011a922042ee9ba691b94d055d|1174|0x13
0|29|libxul.so|mozilla::SchedulerGroup::Runnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|295|0x15
0|30|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|1176|0x15
0|31|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|486|0x11
0|32|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|88|0xa
0|33|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:5cc220ddf028de011a922042ee9ba691b94d055d|315|0x17
0|34|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:5cc220ddf028de011a922042ee9ba691b94d055d|290|0x8
0|35|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|137|0xd
0|36|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|911|0x11
0|37|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|238|0x5
0|38|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:5cc220ddf028de011a922042ee9ba691b94d055d|315|0x17
0|39|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:5cc220ddf028de011a922042ee9ba691b94d055d|290|0x8
0|40|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|749|0xc
0|41|firefox-bin|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|56|0x14
0|42|firefox-bin|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:5cc220ddf028de011a922042ee9ba691b94d055d|263|0x11
0|43|libc-2.27.so||||0x21b97
0|44|firefox-bin|MOZ_ReportCrash|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:5cc220ddf028de011a922042ee9ba691b94d055d|184|0x5

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Minor cleanup of original testcase.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

This doesn't seem particularly serious given it just truncates the int, but shouldn't this:

https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/dom/canvas/WebGLContextGL.cpp#533

Bail us out early?

Comment 3

[Kelsey Gilbert [:jgilbert]]

Hmm, it would be nice if it dumped the offending value.