1555110 - disable cert_storage on non-nightly builds

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

cert_storage is making early beta too unstable due to lmdb crash bugs like bug 1538541 and bug 1550174, so we should restrict it to nightly-only for now.

Comment 1

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: bug 1555110 - Backed out changeset a187487af38a to disable cert_storage on non-nightly builds r?froydnj r?jcj

There are ongoing lmdb issues we need to sort out before we can ship
cert_storage (see e.g. bug 1538541 and bug 1550174).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d643940d96e
Backed out changeset a187487af38a to disable cert_storage on non-nightly builds r=jcj,froydnj

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6d643940d96e

Comment 4

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 9068152 [details]
bug 1555110 - Backed out changeset a187487af38a to disable cert_storage on non-nightly builds r?froydnj r?jcj

Beta/Release Uplift Approval Request

• User impact if declined: startup crashes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This reverts bug 1548365, so it should be safe.
• String changes made/needed: none

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9068152 [details]
bug 1555110 - Backed out changeset a187487af38a to disable cert_storage on non-nightly builds r?froydnj r?jcj

turn off cert_storage on beta to avoid crashes, approved for 68.0b7

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/44ec76478317