1555152 - Make the 'aUsernameField' and 'aPasswordField' nsILoginInfo fields optional

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Matthew N. [:MattN]]

They aren't useful so requiring them in tests just wastes time and makes the API messier.

I'm not removing them now since that will break Thunderbird.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1555152 - Make the 'aUsernameField' and 'aPasswordField' nsILoginInfo fields optional. r=sfoster

I'm not removing them now since that will break Thunderbird.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1555152 - Rename `looseActionOriginMatch` to `ignoreActionAndRealm` to be more correct. r=sfoster

A loose actionOrigin match is achieved using "" for the formSubmitURL whereas the option also includes HTTP auth logins with a null formSubmitURL.

Depends on D32426

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4acef8debaf9
Make the 'aUsernameField' and 'aPasswordField' nsILoginInfo fields optional. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/5a505c13722f
Rename `looseActionOriginMatch` to `ignoreActionAndRealm` to be more correct. r=sfoster

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4acef8debaf9
https://hg.mozilla.org/mozilla-central/rev/5a505c13722f